fix(language-server): Only enable language service on open projects #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After `ngcc` finishes, only enable language service for projects that are open. This avoids an error that would otherwise be thrown by TypeScript. It's not entirely clear what causes the project to close immediately after opening, but it appears to be triggered by having files open from multiple projects. The files not actively being displayed in the editor have their projects closed, but this also only appears to happen after having the editor open for a long time. Fixes angular#1438 Fixes angular#1399 - Not entirely sure this fixes the issue there, but it may and we don't currently have any other indicators for what the issue there might be if the cause is different.
atscott
force-pushed
the
enableProjectOnlyIfNotClosed
branch
from
9556888 to
ebf45f0
Compare
atscott
added a commit
that referenced
this pull request
Jul 28, 2021
…1461) After `ngcc` finishes, only enable language service for projects that are open. This avoids an error that would otherwise be thrown by TypeScript. It's not entirely clear what causes the project to close immediately after opening, but it appears to be triggered by having files open from multiple projects. The files not actively being displayed in the editor have their projects closed, but this also only appears to happen after having the editor open for a long time. Fixes #1438 Fixes #1399 - Not entirely sure this fixes the issue there, but it may and we don't currently have any other indicators for what the issue there might be if the cause is different. (cherry picked from commit 30c4996)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
ngccfinishes, only enable language service for projects thatare open. This avoids an error that would otherwise be thrown by TypeScript.
It's not entirely clear what causes the project to close immediately
after opening, but it appears to be triggered by having files open from
multiple projects. The files not actively being displayed in the editor
have their projects closed, but this also only appears to happen after
having the editor open for a long time.
Fixes #1438
Fixes #1399 - Not entirely sure this fixes the issue there, but it may
and we don't currently have any other indicators for what the issue
there might be if the cause is different.