Skip to content

Commit

Permalink
feat(logs): add chrome logs command line option
Browse files Browse the repository at this point in the history
  • Loading branch information
cnishina committed Mar 25, 2016
1 parent 15ae0e8 commit f0622d2
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
1 change: 1 addition & 0 deletions lib/cmds/opts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ export class Opts {
static versionsChrome = new Option('versions_chrome', 'Optional chrome driver version', 'string', ChromeDriver.versionDefault);
static versionsStandAlone = new Option('versions_standalone', 'Optional seleniuim standalone server version', 'string', StandAlone.versionDefault);
static versionsIe = new Option('versions_ie', 'Optional internet explorer driver version', 'string', IEDriver.versionDefault);
static chromeLogs = new Option('chrome_logs', 'File path to chrome logs', 'string', undefined);
}
14 changes: 13 additions & 1 deletion lib/cmds/start.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ let prog = new Program()
.addOption(Opts.outputDir)
.addOption(Opts.seleniumPort)
.addOption(Opts.versionsStandAlone)
.addOption(Opts.versionsChrome);
.addOption(Opts.versionsChrome)
.addOption(Opts.chromeLogs);

if (os.type() === 'Windows_NT') {
prog.addOption(Opts.versionsIe);
Expand Down Expand Up @@ -48,6 +49,14 @@ function start(options: Options) {
outputDir = path.resolve(Config.baseDir, options['out_dir'].getString());
}
}
let chromeLogs: string = null;
if (options['chrome_logs'].getString()) {
if (path.isAbsolute(options['chrome_logs'].getString())) {
chromeLogs = options['chrome_logs'].getString();
} else {
chromeLogs = path.resolve(Config.baseDir, options['chrome_logs'].getString());
}
}
binaries[StandAlone.id].versionCustom = options['versions_standalone'].getString();
binaries[ChromeDriver.id].versionCustom = options['versions_chrome'].getString();
if (options['versions_ie']) {
Expand All @@ -69,6 +78,9 @@ function start(options: Options) {
args.push(
'-Dwebdriver.chrome.driver=' +
path.join(outputDir, binaries[ChromeDriver.id].executableFilename(osType)));
if (chromeLogs != null) {
args.push('-Dwebdriver.chrome.logfile=' + chromeLogs);
}
}
if (downloadedBinaries[IEDriver.id] != null) {
args.push(
Expand Down

0 comments on commit f0622d2

Please sign in to comment.