-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax error when using version 10.2.9 #170
Comments
This commit changed the build target from ES5 to ES6, effectively dropping support for node 4. This was recognized — it’s mentioned in the changelog ("with node 6 on LTS, we can update the tsconfig to es6") and the test config was changed to remove node 4. While I don’t see an explicit statement about what versions of Node are intended to be supported, the fact that up until that point it had been tested against 4 seems to imply that node 4 was supported, prior to 10.2.9. I think it may be a mistake that this was a patch bump. |
Is the versioning of |
We are experiencing the same |
Same issue on my CI. I think that version 10.2.10 which roll back the node 4 removal would be quite helpful. |
I agree, please create a release with roll back to node 4 support. |
Temp fixes could be:
for those who use node 4.5. This will first wait during the create a file (webdriver.manager.fix.js) in your root and add this
and add this in your package.json
|
I'll roll this back tomorrow. Sorry about that... I'll do a release with fixes and try to get around the spread syntax issue with node 4. You could shrink wrap your webdriver-manager if you want or just wait for the fix tomorrow. Node 6 is in LTS and we'll be moving forward with that soon. |
I think what I'll do is unpublish package 10.2.9. Simply deprecating the change in npm appears that it would still install 10.2.9. Rolling back the change to 10.2.8 and publishing it again to the latest 10.2.10 feels wrong. So unpublishing will leave the latest hot fix as 10.2.8 and I'll publish these changes with 11.0.0. (Keeping with semantic versioning).
|
@cnishina |
|
Very nice and very quick!! |
Huzzah. Done! Sorry about that everyone...I end up switching node versions with nvm so often that I forget that upgrading node is a breaking change. |
Shit happens ;-). Again tnx for fixing this very fast! |
I'm still seeing 10.2.9 in the version list
|
Leaving this open so people encountering the same issue will see it. |
Hello! Webdriver-manager 10.2.9 was published earlier today and it was causing problems because it requires node 6. To resolve this problem, I unpublished 10.2.9. What this means is that you'll just need to remove the node_module for webdriver-manager and do a fresh Version 11.0.0 was published after that with notes on breaking change for node 6. |
Will close this issue next week. |
But 10.2.9 is still in NPM, I thought you removed it |
10.2.9 has been removed.
|
Also, created a stackoverflow that references this issue. |
@wswebcreation is it possibly cached? You could potentially delete the cached version |
It was not cached, the log I pasted was from the npm command, before is wasn't showing. I'll do a fresh install now on my local machine (new install of project en modules). If you hear nothing it's fixed ;-) |
Alright, well I'm headed to bed so fingers crossed! |
It's running now! |
Thanks for the quick fix. There's some issues for people using caching layers like Artifactory though. It's not so simple to delete releases there and it might even be prohibited by legal requirements (Entreprise problems;-). So when using a proper semantic versioned dependency like And it's even trickier: packages like So I propose to re-release a version 10.2.10, reverting the change, including an updated changelog. |
@huerlisi I did think about Artifactory last night and was hoping no one had that problem. I'll cut a release for 10.2.8 to be 10.2.10 and update the changelog. |
Quick update. 10.2.10 has been released to resolve caching layers like Artifactory w/ an updated changelog. Thanks @huerlisi. |
Node/npm/overall noob and dummy here... why would anyone ever pull down a version of something instead of releasing a new version that reverts or fixes the issue? Do you force push to change history in your git branches too? |
@tomreece It was late last night and made a decision. That decision although was not probably the right decision, I later released a new version with the reverted change. In regards to your comment about force pushing changes, the master branch does not allow force pushing so I just added another commit with some updates on the changelog. I hope that helps. |
@cnishina your fast response is very much appreciated! |
It's been a week. Closing this issue! |
- version 10.2.9 unpublished from npm and tag removed from github due to breaking change with requiring node 6 LTS closes angular#170
- version 10.2.9 unpublished from npm and tag removed from github due to breaking change with requiring node 6 LTS closes angular#170
- version 10.2.9 unpublished from npm and tag removed from github due to breaking change with requiring node 6 LTS closes angular#170
- version 10.2.9 unpublished from npm and tag removed from github due to breaking change with requiring node 6 LTS closes angular#170
This is still broken for Node.js@4.x.x. I don't understand why support for 4.x.x was dropped when it's still in active LTS until 2017-04-01 (3 months left) and being maintained until 2018-04-01 (15 months left) =/ https://github.com/nodejs/LTS/tree/772147f5d1493a13851084dd8f262352c64e5fbd |
I am still facing this issue. Please suggest the solution |
Have you tried updating to node > 7 with NVM? |
Yes I have also tried with node v7.4.0 but faced same problem |
This is my setup and I don't have the problem. |
Are you really saying the current version of node and npm in ubuntu:16.04 (and even 16.10!) is too old to support? Really seems like you should either get Ubuntu repos updated to a more recent nodejs, or support the "current" node on LTS releases. Example Dockerfile reproducing the failure:
Or I guess I should be running https://deb.nodesource.com/setup to install node instead of using apt-get? Yup, this works:
|
vegan@vegan: but still not working. chromedriver is up to date. |
@caneraydinbey Not sure what the context of the comment above is about. Looks like you are installing a really old version of protractor. You should try to stay current. |
Also, I'm planning to lock this conversation since it has been resolved. Please open up a new issues. Closed issues do not get a lot of attention. |
After updating to the newest version, I get the following error on running 'webdriver-manager' command.
C:\Users\(user)\AppData\Roaming\npm\node_modules\webdriver-manager\built\lib\cli\logger.js:66
info(...msgs) {
^^^
SyntaxError: Unexpected token ...
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:373:25)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at Object. (C:\Users\(user)\AppData\Roaming\npm\node_modules\we
bdriver-manager\built\lib\cli\index.js:8:10)
at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
The text was updated successfully, but these errors were encountered: