feat(shutdown): do not error if you try to shutdown a server which is already off #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… already off When scripting, you might want to defensively run a `shutdown` command. If the shutdown fails because the server is already off, you don't care. If it fails for another reason, you do care. So I made trying to shutdown a server which is already off just a warning. I added a flag in case you want the old behavior though.
Merged
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 16, 2016
… already off (angular#162) When scripting, you might want to defensively run a `shutdown` command. If the shutdown fails because the server is already off, you don't care. If it fails for another reason, you do care. So I made trying to shutdown a server which is already off just a warning. I added a flag in case you want the old behavior though.
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 20, 2016
… already off (angular#162) When scripting, you might want to defensively run a `shutdown` command. If the shutdown fails because the server is already off, you don't care. If it fails for another reason, you do care. So I made trying to shutdown a server which is already off just a warning. I added a flag in case you want the old behavior though.
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 20, 2016
… already off (angular#162) When scripting, you might want to defensively run a `shutdown` command. If the shutdown fails because the server is already off, you don't care. If it fails for another reason, you do care. So I made trying to shutdown a server which is already off just a warning. I added a flag in case you want the old behavior though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scripting, you might want to defensively run a
shutdowncommand. If the shutdown failsbecause the server is already off, you don't care. If it fails for another reason, you do care.
So I made trying to shutdown a server which is already off just a warning. I added a flag in case
you want the old behavior though.