This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 408
requestAnimationFrame should return native handleId or cancelAF should accept TimerOption #360
Comments
lacolaco
changed the title
requestAnimationFrame should return native handleId
requestAnimationFrame should return native handleId or cancelAF should accept TimerOption
Jun 13, 2016
Repro (with Angular2): http://plnkr.co/edit/MmQmT8YAbOyg8kh3pnQX?p=preview |
This was referenced Jun 13, 2016
Maybe related to #359 |
I think zone.js should not change the signature of any native APIs. Is there a list of all patches that do not preserve the original signature? |
AFAIK, set/clearInterval and set/clearTimeout seems working as well as its native behavior. |
@IgorMinar how do you think about this? |
Fixed in latest zone.js. http://plnkr.co/edit/JJCleR?p=preview |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From angular/angular#8401
Currently, zone-patched
requestAnimationFrame
returnsZoneTask
.It seems breaking native rAF canceling:
To cancel rAF, we have to use
data.handleId
The text was updated successfully, but these errors were encountered: