Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Unhandled Promise rejection: TypeError: Cannot set property 'name' of undefined #554

Closed
filipesilva opened this issue Dec 20, 2016 · 4 comments
Closed

Unhandled Promise rejection: TypeError: Cannot set property 'name' of undefined #554

filipesilva opened this issue Dec 20, 2016 · 4 comments

Comments

@filipesilva
Copy link

Using zone.js@0.7.3, Angular 2 routerLink does not work properly whereas with zone.js@0.7.2 it did.

Here is a repro plunker: https://plnkr.co/edit/SYPR2SRi0xayQ693jJAB?p=preview
It is a simple list with a couple of links. Clicking on any link breaks the app with the following console error:

zone.js@0.7.3?main=browser:405 Unhandled Promise rejection: TypeError: Cannot set property 'name' of undefined
    at new EmptyError (VM20135 EmptyError.js:21)
    at FirstSubscriber._complete (VM20134 first.js:147)
// ...

In index.html if you revert https://unpkg.com/zone.js@0.7.3 to 0.7.2 the app works again.
@JiaLiPassion
Copy link
Collaborator

@filipesilva , sorry, it is my mistake, I didn't return this in PR #547, I'll make a PR now.

@filipesilva
Copy link
Author

@JiaLiPassion if I understand your PR correctly, it should only affect errors themselves. This scenario should not result in an error at all though, since it worked with 0.7.2 without throwing errors.

JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue Dec 20, 2016
@JiaLiPassion
fix angular#555, fix angular#554, error should return itself from con…
f166f4a 
…structor, and copy native error's properties
@filipesilva filipesilva mentioned this issue Dec 20, 2016
Merged
filipesilva added a commit to angular/quickstart that referenced this issue Dec 20, 2016
@filipesilva
fix(deps): pin webdriver and zone.js
d2527a2 
When angular/protractor#3848 is ready it should fix the webdriver types issues, and the pinning can be reverted.

The zone.js problem is being tracked on angular/zone.js#554.

Fix #325
@filipesilva filipesilva mentioned this issue Dec 20, 2016
Merged
filipesilva added a commit to angular/quickstart that referenced this issue Dec 20, 2016
@filipesilva
fix(deps): pin webdriver and zone.js (#330)
d8c3cba 
When angular/protractor#3848 is ready it should fix the webdriver types issues, and the pinning can be reverted.

The zone.js problem is being tracked on angular/zone.js#554.

Fix #325
@chuckjaz
Copy link
Contributor

This has been fixed with 0.7.4

@JiaLiPassion JiaLiPassion mentioned this issue Dec 20, 2016
Closed
JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue Dec 20, 2016
@JiaLiPassion
Fix angular#546, angular#554, angular#555, the error should keep prot…
1815d81 
…otype chain and can be called without new
@JiaLiPassion JiaLiPassion mentioned this issue Dec 20, 2016
Merged
@blueskyfish
Copy link

Hi Guys,

Thanks for the solve of the zone.js in version 0.7.4. 👍 :-)

@henioStraszny henioStraszny mentioned this issue Jan 2, 2017
Closed
@brianghig brianghig mentioned this issue Jan 3, 2017
Closed
mhevery pushed a commit that referenced this issue Jan 6, 2017
@JiaLiPassion @mhevery
fix(ZoneAwareError): Error should keep prototype chain and can be cal…
82722c3 
…led without new

Fix #546, #554, #555
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chuckjaz @JiaLiPassion @blueskyfish @filipesilva