Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

unhandledrejection tests are failing in recent version of Chrome #718

Closed
marclaval opened this issue Apr 4, 2017 · 1 comment · Fixed by #726
Closed

unhandledrejection tests are failing in recent version of Chrome #718

marclaval opened this issue Apr 4, 2017 · 1 comment · Fixed by #726

Comments

@marclaval
Copy link
Contributor

In fact, they never complete and the browser ends up disconnecting.
I've tried in Chrome 52, 54 and 57.

The 3 tests in sccope are: https://github.com/angular/zone.js/blob/master/test/browser/browser.spec.ts#L242-L314
@marclaval marclaval mentioned this issue Apr 4, 2017
Merged
@JiaLiPassion
Copy link
Collaborator

JiaLiPassion commented Apr 6, 2017 •
edited
Loading

@Mlaval, I make a PR to fix this one in #726, please review.

JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue Apr 6, 2017
@JiaLiPassion
fix(test): fix angular#718, use async test to do unhandle promise rej…
7686da0 
…ection test
@JiaLiPassion JiaLiPassion mentioned this issue Apr 6, 2017
Merged
JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue Apr 6, 2017
@JiaLiPassion
fix(test): fix angular#718, use async test to do unhandle promise rej…
5f1fee6 
…ection test
JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue Apr 10, 2017
@JiaLiPassion
fix(test): fix angular#718, use async test to do unhandle promise rej…
48cb5ee 
…ection test
mhevery pushed a commit that referenced this issue Apr 21, 2017
@JiaLiPassion @mhevery
fix(test): fix #718, use async test to do unhandle promise rejection …
0a06874 
…test (#726)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test): fix #718, use async test to do unhandle promise rejection test JiaLiPassion/zone.js
2 participants
@JiaLiPassion @marclaval