Socket.IO

[Kaffiend]

Is there a way we can get Socket.io to run within zone? or will we manually have to run every socket callback through zone?

[JiaLiPassion]

@Kaffiend ，currently you have to use Zone.current.wrap(callback) yourself, I can implement a patch for socket.io later.

[brgaulin]

I guarantee this is not optimal, but the only way I found to wrap the emitter .on event, was something like this:

let socketOn = socket.on;
socket.on = (event: string, fn: () => any) => {
  let wrappedFunction = function() {
    let args = arguments;
    zone.run(() => fn.apply(this, args));
  };
  return socketOn.apply(socket, [event, wrappedFunction]);
};

[brgaulin]

Although, its weird. I do see that websockets themselves are wrapped. socket.io uses the Component Emitter for handling its events: https://www.npmjs.com/package/component-emitter

[Kaffiend]

I added ngrx to manage state better and discovered that onPush change detection and async slices of state updated from my socket services makes this work just fine. Not saying it doesnt need patched for other implementations without a reactive library for angular in use.

[Kaffiend]

Will zone be patched any time soon for Socket.IO?

[JiaLiPassion]

@Kaffiend , I am working on it, I will create a PR soon.