Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

0.8.17 seems broken on IE #911

Closed
marcovdb opened this issue Sep 20, 2017 · 6 comments · Fixed by #913
Closed

0.8.17 seems broken on IE #911

marcovdb opened this issue Sep 20, 2017 · 6 comments · Fixed by #913

Comments

@marcovdb
Copy link

marcovdb commented Sep 20, 2017

Using Zone.js 0.8.17, my application fails in IE11 with the following error message:

SCRIPT5007: Unable to get property 'type' of undefined or null reference
zone.js (196,25)

Reverting to 0.8.16 fixes the issue.

@JiaLiPassion
Copy link
Collaborator

@marcovdb ,could you provide a reproduce repo? Or could you help me to debug the error detail? thank you!

@marcovdb
Copy link
Author

Sure, happy to help.

I modified zone.js to log the offending task to the console and this is what it's telling me:

image

I don't know if that is helpful at all?

@JiaLiPassion
Copy link
Collaborator

@marcovdb ,could you show me the source location where the error throw? and which object is undefined? thank you.

@marcovdb
Copy link
Author

marcovdb commented Sep 21, 2017

"TypeError: Unable to get property 'type' of undefined or null reference
   at wrapFn (eval code:1071:5)
   at loadreadystatechange (eval code:48:9)
   at oninterval (eval code:77:33)
   at Anonymous function (eval code:15:23144)
   at d (eval code:15:23122)
   at ZoneDelegate.prototype.invokeTask (eval code:424:13)
   at Zone.prototype.runTask (eval code:192:21)
   at ZoneTask.invokeTask (eval code:500:17)
   at invoke (eval code:489:21)
   at timer (eval code:1897:17)"

Seems like at some point, wrapFn gets called with an undefined event.

I tried 0.8.16 again (because I could not find any differences between 0.8.14 and .16 relating to wrapFn) and it works fine. So I was incorrect in stating the issue is in 0.8.16 too, it's just 0.8.17. Sorry about that! Something in a66595a must be causing the issue.

@marcovdb marcovdb changed the title 0.8.16+ seems broken on IE 0.8.17 seems broken on IE Sep 21, 2017
@JiaLiPassion
Copy link
Collaborator

JiaLiPassion commented Sep 21, 2017

@marcovdb , thank you for the information, so about the stacktrace, I still need to know the target and eventName, for example, if we call button.onclick = function() {}, then button is target, and click is eventName, so could you help me to find those information by checking the loadreadystatechange, oninterval and other stack frames?

Could you try the attached zone.js.zip?
zone.js.zip

@marcovdb
Copy link
Author

image

The attached zone.js works fine :) No issues with that one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants