This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(eventListener): use the correct WTF issue array to iterate on #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jahtalab , thank you for the fix, this my typo, it will not affect the main functionality, just a little performance impact. |
JiaLiPassion
approved these changes
Jun 15, 2018
|
@jahtalab, could you rebase your PR, the CI failed because your |
|
@jahtalab, sorry this PR takes so long, the PR doesn't been merged because it need rebase, now zone.js has been moved to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that zone.js iterates on the wrong array while considering WTF issue. This results in a lot of unnecessary iterations and object creations. Although it seems that the main functionality is not affected.