-
Notifications
You must be signed in to change notification settings - Fork 408
feat(build): Upgrade to TypeScript 2.9 and rxjs6 #1122
Conversation
This includes a migration to TS2.9, and a migration to RxJS 6 (which is required for TS2.9 support).
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@googlebot I herewith confirm that I am OK with my commits being contributed to this project. |
@JiaLiPassion , and @mprobst @googlebot can we please complete this PR! It's literally that last thing stopping me from completing my last step in RxJS 6 process which is removing rxjs-compat.... Come on now! The updated was like back in April... |
@sssalib42, I am not sure the release schedule, please use the following branch as temp test solution.
|
Would somebody please satisfy this horny bot? |
@arusak, the |
Sorry JiaLiPassion, my team isn't comfortable with using a non-production copy of the code. Author consent!? How can we fix the cal/google error requiring an author consent verification? |
@IgorMinar @mhevery @robwormald @StephenFluin @alxhub @benlesh Angular 7 is coming out in the next few weeks and we still can't completely upgrade to Angular 6! |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
1 similar comment
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
Thank you @mhevery!!! I'm so happy to have come so close from interacting with the founder, and the man who started it all. The Father of Angular :):):) |
This includes a migration to TS2.9, and a migration to RxJS 6 (which is required for TS2.9 support).
fix #1091.
And this PR is based on #1104, thanks for @mprobst's great help!