Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

feat(build): Upgrade to TypeScript 2.9 and rxjs6 #1122

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

JiaLiPassion
Copy link
Collaborator

This includes a migration to TS2.9, and a migration to RxJS 6 (which is required for TS2.9 support).

fix #1091.

And this PR is based on #1104, thanks for @mprobst's great help!

This includes a migration to TS2.9, and a migration to RxJS 6 (which is required for TS2.9 support).
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@mprobst
Copy link
Contributor

mprobst commented Jul 30, 2018

@googlebot I herewith confirm that I am OK with my commits being contributed to this project.

@sssalib42
Copy link

@JiaLiPassion , and @mprobst @googlebot can we please complete this PR! It's literally that last thing stopping me from completing my last step in RxJS 6 process which is removing rxjs-compat....

Come on now! The updated was like back in April...

@JiaLiPassion
Copy link
Collaborator Author

@sssalib42, I am not sure the release schedule, please use the following branch as temp test solution.
update the package.json

"zone.js": "git://github.com/JiaLiPassion/zone.js#ts29-fix-dist"

@arusak
Copy link

arusak commented Aug 31, 2018

Would somebody please satisfy this horny bot?

@JiaLiPassion
Copy link
Collaborator Author

@arusak, the bot is not a real issue, after the review, it can be merged ignore this bot error.

@sssalib42
Copy link

sssalib42 commented Sep 6, 2018

Sorry JiaLiPassion, my team isn't comfortable with using a non-production copy of the code.

Author consent!? How can we fix the cal/google error requiring an author consent verification?
@JiaLiPassion @mprobst @googlebot

@sssalib42
Copy link

@IgorMinar @mhevery @robwormald @StephenFluin @alxhub @benlesh

Angular 7 is coming out in the next few weeks and we still can't completely upgrade to Angular 6!

@mhevery mhevery added cla: yes and removed cla: no labels Sep 6, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

1 similar comment
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@mhevery mhevery merged commit 31fc127 into angular:master Sep 6, 2018
@sssalib42
Copy link

Thank you @mhevery!!! I'm so happy to have come so close from interacting with the founder, and the man who started it all. The Father of Angular :):):)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RxJs 6 Support
6 participants