This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(node): fix #1164, don't patch uncaughtException to prevent endless loop. #1170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1164.
in
nodejs 10
, there is a logic indomain.js
.here
listener !== domainUncaughtExceptionClear
will crashzone
, becauselistener
will bezoneTask.invoke
instead of the original listener.So this PR will just
bypass
uncaughtException
.also update the
travis CI
tonodejs 10
, to makenodejs 10
work, I updatedyarn.lock
to updatenatives to 1.1.3
, otherwisegulp
will not work. gulpjs/gulp#2162