Cleaning up some unused code and adding ValueTuple support to make un…

…it abbreviations a bit clearer
angularsen · Oct 17, 2018 · a3d0435 · a3d0435
1 parent 876f31f
commit a3d0435
Show file tree

Hide file tree

Showing 7 changed files with 999 additions and 1,124 deletions.
diff --git a/UnitsNet/CustomCode/UnitAbbreviationsCache.cs b/UnitsNet/CustomCode/UnitAbbreviationsCache.cs
@@ -65,8 +65,8 @@ private void LoadGeneratedAbbreviations()
         {
             foreach(var localization in GeneratedLocalizations)
             {
-                var culture = new CultureInfo(localization.Item1);
-                MapUnitToAbbreviation(localization.Item2, localization.Item3, culture, localization.Item4);
+                var culture = new CultureInfo(localization.CultureName);
+                MapUnitToAbbreviation(localization.UnitType, localization.UnitValue, culture, localization.UnitAbbreviations);
             }
         }
 

diff --git a/UnitsNet/GeneratedCode/UnitAbbreviationsCache.g.cs b/UnitsNet/GeneratedCode/UnitAbbreviationsCache.g.cs
diff --git a/UnitsNet/I18n/AbbreviationsForCulture.cs b/UnitsNet/I18n/AbbreviationsForCulture.cs
diff --git a/UnitsNet/I18n/CulturesForEnumValue.cs b/UnitsNet/I18n/CulturesForEnumValue.cs
diff --git a/UnitsNet/I18n/UnitLocalization.cs b/UnitsNet/I18n/UnitLocalization.cs
diff --git a/UnitsNet/Scripts/Include-GenerateUnitSystemDefaultSourceCode.ps1 b/UnitsNet/Scripts/Include-GenerateUnitSystemDefaultSourceCode.ps1
@@ -39,10 +39,6 @@
 // THE SOFTWARE.
 
 using System;
-using System.Globalization;
-using System.Collections.Generic;
-using System.Collections.ObjectModel;
-using UnitsNet.I18n;
 using UnitsNet.Units;
 
 // ReSharper disable RedundantCommaInArrayInitializer
@@ -52,8 +48,8 @@ namespace UnitsNet
 {
     public partial class UnitAbbreviationsCache
     {
-        private static readonly Tuple<string, Type, int, string[]>[] GeneratedLocalizations
-            = new Tuple<string, Type, int, string[]>[]
+        private static readonly (string CultureName, Type UnitType, int UnitValue, string[] UnitAbbreviations)[] GeneratedLocalizations
+            = new []
             {
 "@;
     foreach ($quantity in $quantities) 
@@ -70,7 +66,7 @@ namespace UnitsNet
                 $cultureName = $localization.Culture;
                 $abbreviationParams = $localization.Abbreviations -join '", "'
 @"
-                Tuple.Create(`"$cultureName`", typeof($unitEnumName), (int)$unitEnumName.$enumValue, new string[]{`"$abbreviationParams`"}),
+                (`"$cultureName`", typeof($unitEnumName), (int)$unitEnumName.$enumValue, new string[]{`"$abbreviationParams`"}),
 "@;
             }
         }

diff --git a/UnitsNet/UnitsNet.Common.props b/UnitsNet/UnitsNet.Common.props
@@ -28,6 +28,7 @@
   <!-- NuGet references that work for both signed and unsigned -->
   <ItemGroup>
     <PackageReference Include="JetBrains.Annotations" Version="10.4.0" PrivateAssets="All" />
+    <PackageReference Include="System.ValueTuple" Version="4.5.0" />
   </ItemGroup>
 
   <!-- Exclude obj folder from default inclusion pattern -->