Density Conversions are Incorrect

[massonib]

I found four errors in the density conversions. Please see below.

public double KilogramsPerCubicCentimeter
{
//Was this // get { return _kilogramsPerCubicMeter_0.00000001; }
get { return kilogramsPerCubicMeter 1e-6; }
}

    public double KilogramsPerCubicMillimeter
    {
        //Was this // get { return _kilogramsPerCubicMeter*0.000000000001; }
        get { return _kilogramsPerCubicMeter*1e-9; }
    }

    public double TonnesPerCubicCentimeter
    {
        //Was this // get { return _kilogramsPerCubicMeter*0.00000000001; }
        get { return _kilogramsPerCubicMeter* 1e-9; }
    }

    public double TonnesPerCubicMillimeter
    {
        //Was this // get { return _kilogramsPerCubicMeter*0.000000000000001; }
        get { return _kilogramsPerCubicMeter* 1e-12; }
    }

[eriove]

Hmm. Looking at the tests and comparing it to Googles unit conversion these seems to be correct.

    protected override double KilogramsPerCubicCentimeterInOneKilogramPerCubicMeter => 1e-6;

    protected override double KilogramsPerCubicMillimeterInOneKilogramPerCubicMeter => 1e-9;

    protected override double TonnesPerCubicCentimeterInOneKilogramPerCubicMeter => 1e-9;

    protected override double TonnesPerCubicMillimeterInOneKilogramPerCubicMeter => 1e-12;

But just looking at this code it seems wrong...

Not sure what I'm missing.

[massonib]

Yes, those are correct. The error is in the Density.g.cs file in the properties region.

[massonib]

New .json file

{
"Name": "Density",
"BaseUnit": "KilogramPerCubicMeter",
"XmlDoc": "The density, or more precisely, the volumetric mass density, of a substance is its mass per unit volume.",
"XmlDocRemarks": "http://en.wikipedia.org/wiki/Density",
"Units": [
{
"SingularName": "KilogramPerCubicMillimeter",
"PluralName": "KilogramsPerCubicMillimeter",
"FromUnitToBaseFunc": "x_1e+9",
"FromBaseToUnitFunc": "x_1e-9",
"Localization": [
{
"Culture": "en-US",
"Abbreviations": [ "kg/mm³" ]
}
]
},
{
"SingularName": "KilogramPerCubicCentimeter",
"PluralName": "KilogramsPerCubicCentimeter",
"FromUnitToBaseFunc": "x_1e+6",
"FromBaseToUnitFunc": "x_1e-6",
"Localization": [
{
"Culture": "en-US",
"Abbreviations": [ "kg/cm³" ]
}
]
},
{
"SingularName": "KilogramPerCubicMeter",
"PluralName": "KilogramsPerCubicMeter",
"FromUnitToBaseFunc": "x",
"FromBaseToUnitFunc": "x",
"Localization": [
{
"Culture": "en-US",
"Abbreviations": [ "kg/m³" ]
},
{
"Culture": "ru-RU",
"Abbreviations": [ "кг/м³" ]
}
]
},
{
"SingularName": "PoundPerCubicInch",
"PluralName": "PoundsPerCubicInch",
"FromUnitToBaseFunc": "x_27679.904710191",
"FromBaseToUnitFunc": "x/27679.904710191",
"Prefixes": [ "Kilo" ],
"Localization": [
{
"Culture": "en-US",
"Abbreviations": [ "lb/in³" ],
"AbbreviationsWithPrefixes": [ "kip/in³" ]
}
]
},
{
"SingularName": "PoundPerCubicFoot",
"PluralName": "PoundsPerCubicFoot",
"FromUnitToBaseFunc": "x/0.062427961",
"FromBaseToUnitFunc": "x_0.062427961",
"Prefixes": [ "Kilo" ],
"Localization": [
{
"Culture": "en-US",
"Abbreviations": [ "lb/ft³" ],
"AbbreviationsWithPrefixes": [ "kip/ft³" ]
}
]
},
{
"SingularName": "TonnePerCubicMillimeter",
"PluralName": "TonnesPerCubicMillimeter",
"FromUnitToBaseFunc": "x_1e+12",
"FromBaseToUnitFunc": "x_1e-12",
"Localization": [
{
"Culture": "en-US",
"Abbreviations": [ "t/mm³" ]
}
]
},
{
"SingularName": "TonnePerCubicCentimeter",
"PluralName": "TonnesPerCubicCentimeter",
"FromUnitToBaseFunc": "x_1e+9",
"FromBaseToUnitFunc": "x_1e-9",
"Localization": [
{
"Culture": "en-US",
"Abbreviations": [ "t/cm³" ]
}
]
},
{
"SingularName": "TonnePerCubicMeter",
"PluralName": "TonnesPerCubicMeter",
"FromUnitToBaseFunc": "x_1000",
"FromBaseToUnitFunc": "x_0.001",
"Localization": [
{
"Culture": "en-US",
"Abbreviations": [ "t/m³" ]
}
]
}
]
}

[massonib]

Created pull request with fix.

[angularsen]

Fixed in #173