Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added short and long tons. #1

Merged
merged 1 commit into from
Jul 22, 2013
Merged

Added short and long tons. #1

merged 1 commit into from
Jul 22, 2013

Conversation

distantcam
Copy link
Contributor

http://en.wikipedia.org/wiki/Short_ton
http://en.wikipedia.org/wiki/Long_ton

Also known as the US ton and the UK ton, these are currently the bane of my existence.

Thankyou for releasing this library. My team is constantly having to convert things and this will help.

@angularsen angularsen merged commit 4347990 into angularsen:master Jul 22, 2013
@angularsen
Copy link
Owner

Thanks for contributing and for following the code style.
Found one mistake though, the short and long tons were implemented the other way around.

You wrote:
Assert.AreEqual(907.18474, oneKg.ShortTons, Delta);
Assert.AreEqual(1016.0469088, oneKg.LongTons, Delta);

One kg is not 907 short tons :-)

Corrected it and merged it.

@distantcam
Copy link
Contributor Author

Doh! Of course. This is why I need a library to handle this for me. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants