Added support for molar flow units #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angularsen
requested changes
Feb 9, 2023
dcasaseca
commented
Feb 11, 2023
dcasaseca
commented
Feb 11, 2023
Improve precision of test case
angularsen
requested changes
Feb 12, 2023
|
This is most likely failing because of the property marked as obsolete. I had to make a manual change after running the automatic code generation tool. The manual change was on "NumberToHeatTransferCoefficientExtensionsTest.g.cs" for a missing namespace (System.Obsolete) |
|
@angularsen please have a look, this builds perfectly fine for me |
There is no reason to annotate generated test methods with obsolete attributes. Only the types and methods related to the implementation of the unit needs it, not tests.
|
@dcasaseca I pushed a fix, reverting the manual changes to generated code and instead fixed the code generator to not emit obsolete attribute for test code. This seemed like a mistake in the existing codegen regarding obsolete units. |
|
Thank you for the effort, a lot of new stuff here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.