Add UsGallonsPerMile, ImperialGallonPerMile, MegaukGallonPerDay, MegausGallonPerDay #1225
Conversation
| @@ -40,5 +40,7 @@ public class VolumePerLengthTests : VolumePerLengthTestsBase | |||
| protected override double LitersPerKilometerInOneCubicMeterPerMeter => 1E6; | |||
|
|
|||
| protected override double LitersPerMillimeterInOneCubicMeterPerMeter => 1; | |||
|
|
|||
| protected override double UsGallonsPerMileInOneCubicMeterPerMeter => 4.251439077933434e5; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I think you used the "miles per gallon" constant, instead of "gallons per mile".
There was a problem hiding this comment.
My bad, it seems converters mix and match m/m³ and m³/m and it was easy to confuse.
There was a problem hiding this comment.
I found 4.25143707430272e5 (source)
… MegausGallonPerDay
t03apt
changed the title
Improve precision of test constants
I am sorry about removing wolframalpha comments during merge. Should I add wolframalpha links to any new units in the future? Is there a guideline about it that I missed? |
|
No problem, I added them back. There is no guideline about documenting sources, but I realized this is probably a Good Thing (tm) since we have had a bit more focus on preserving high precision in conversion functions lately. I'll add a note about it in the wiki for adding a new unit. |
|
Sorry for the late turnaround, we usually get things done quicker. Work and family has been eating all my time the past few weeks. Thanks for your effort! Nuget should be out shortly. |
|
Added info about documenting source of value: |
ImperialGallonPerMile
UsGallonPerMile
MegausGallonPerDay
MegaukGallonPerDay