Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added absorbed dose of ionizing radiation units #1255

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Added absorbed dose of ionizing radiation units #1255

merged 3 commits into from
Jun 6, 2023

Conversation

Jagailo
Copy link
Contributor

@Jagailo Jagailo commented Jun 5, 2023

No description provided.

Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few suggestions

@Jagailo
Copy link
Contributor Author

Jagailo commented Jun 6, 2023

image

For your information, several tests fail, because I have Russian Windows installed and environment culture is used for localization. I could fix this in a separate PR if needed.

@angularsen
Copy link
Owner

image For your information, several tests fail, because I have Russian Windows installed and environment culture is used for localization. I could fix this in a separate PR if needed.

Interesting, yes please do take a look at fixing those tests in a separate pull request, that would be great!

@angularsen angularsen merged commit 612489d into angularsen:master Jun 6, 2023
@angularsen
Copy link
Owner

Thanks, great work on this!

Nuget should be out shortly.
Release UnitsNet/5.18.0 · angularsen/UnitsNet

@Jagailo Jagailo deleted the add-absorbed-dose-of-ionizing-radiation-units branch June 6, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants