Implicit cast between Duration and TimeSpan #1365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1354 (comment)
One issue is that the operator overloads only work when
TimeSpan
is the right operand.I changed the code generation to take this into account, but another option would be to make a breaking change where we just don't support
TimeSpan
as the left operand at all.Then users would have to cast explicitly, or for multiplication just reverse the operands.
This would affect 13 operators:
Of which only 6 are used in tests so I assume are supported in v5: