Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LinearDensity.GramPerFoot and prefixes #1392

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

filusma
Copy link
Contributor

@filusma filusma commented Jun 12, 2024

No description provided.

@lipchev
Copy link
Collaborator

lipchev commented Jun 12, 2024

Not sure why the build is failing- but regardless, I think that mixing the two unit systems like that is a bad idea.

Also, I can already see that there is a small rounding error being introduced by putting in the ~ result of 1/0.3048.
For reference, here is how I've defined the PoundPerFoot in the upcoming PR that fixes these issues:

    {
      "SingularName": "PoundPerFoot",
      "PluralName": "PoundsPerFoot",
      "FromUnitToBaseFunc": "{x} * 0.45359237 / 0.3048",
      "FromBaseToUnitFunc": "{x} * 0.3048 / 0.45359237",
      "Localization": [
        {
          "Culture": "en-US",
          "Abbreviations": [ "lb/ft" ]
        }
      ]
    }

@filusma
Copy link
Contributor Author

filusma commented Jun 12, 2024

I think that mixing the two unit systems like that is a bad idea.

I expected that one and said as much too my colleague :) In our industry it is used in practice though, that's why we would like to have it added.

@angularsen
Copy link
Owner

I'm seeing many references to this unit on google, so for me I'm fine adding it.

@filusma Can you improve the precision per @lipchev 's recommendation?

@angularsen angularsen changed the title add g/ft Add GramPerFoot and prefixes Jun 21, 2024
@angularsen angularsen changed the title Add GramPerFoot and prefixes Add LinearDensity.GramPerFoot and prefixes Jun 21, 2024
@angularsen angularsen merged commit 21ce300 into angularsen:master Jun 21, 2024
1 check passed
@filusma filusma deleted the add-gram-per-foot branch June 24, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants