Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Update Length.SolarRadius definition per IAU Res. B3 #1426

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

saadsidqui
Copy link
Contributor

@saadsidqui saadsidqui commented Sep 22, 2024

Fixes #1425

The current value of 6.95510e8 differs from the standardized nominal solar radius value 6.95700e8 defined in IAU Resolution B3 (2015), also on Wikipedia

@saadsidqui saadsidqui marked this pull request as draft September 22, 2024 17:28
@saadsidqui saadsidqui marked this pull request as ready for review September 22, 2024 18:14
@angularsen angularsen changed the title Use the Nominal Solar Radius as defined in IAU Res. B3 ✨Update Length.SolarRadius definition per IAU Res. B3 Sep 29, 2024
@angularsen angularsen merged commit 816f48f into angularsen:master Sep 29, 2024
1 check passed
@angularsen
Copy link
Owner

You should also run generate-code.bat or generate-code.sh after making changes to JSON, to generate new C# files. I'll merge now and do it for you, just a heads up for next time.

More details in https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit

@angularsen
Copy link
Owner

angularsen commented Sep 29, 2024

Thanks by the way, it's good to keep the constants up to date.

I could not find the original reference for this constant and where it was found, the original PR was 5 years ago so maybe it simply was "the current" constant back then on wiki and other places.
#683

@saadsidqui
Copy link
Contributor Author

Thank you and my pleasure to contribute. I will keep in mind to run generate-code.bat next time !

@angularsen
Copy link
Owner

Nuget should be out shortly
Release UnitsNet/5.59.0 · angularsen/UnitsNet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the Nominal Solar Radius as defined in IAU Res. B3
2 participants