Fix a bug in BaseDimensions.IsBaseQuantity() #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygorshkov
changed the title
ygorshkov
force-pushed
the
bugfix/base-dimensions/is-base-quantity
branch
from
0df7b6b to
cb69e34
Compare
angularsen
requested changes
Oct 25, 2024
ygorshkov
force-pushed
the
bugfix/base-dimensions/is-base-quantity
branch
from
9326b75 to
5104c51
Compare
ygorshkov
force-pushed
the
bugfix/base-dimensions/is-base-quantity
branch
from
5104c51 to
9d20fd8
Compare
|
Sorry for being late here, it drowned in my inbox and I forgot it. |
|
Thanks! Nuget should be out shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of
BaseDimensions.IsBaseQuantity()ignores any dimension which power is not1.So it treats derived quantities (like Acceleration shown in unit test) as base ones.
This PR fixes a bug