Fix a bug in BaseDimensions.ToString() #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygorshkov
force-pushed
the
bugfix/base-dimensions/to-string
branch
from
048a7ad to
80f40cc
Compare
ygorshkov
commented
Oct 23, 2024
| @@ -695,7 +695,13 @@ public void CheckBaseDimensionMultiplicationWithForceEqualsMassTimesAcceleration | |||
| [Fact] | |||
| public void CheckToStringUsingMolarEntropy() | |||
| { | |||
| Assert.Equal("[Length]^2[Mass][Time]^-2[Temperature][Amount]", MolarEntropy.BaseDimensions.ToString()); | |||
| Assert.Equal("[Length]^2[Mass][Time]^-2[Temperature]^-1[Amount]^-1", MolarEntropy.BaseDimensions.ToString()); | |||
There was a problem hiding this comment.
|
Thanks! Nuget should be out shortly. |
lipchev
pushed a commit
to lipchev/UnitsNet
that referenced
this pull request
Dec 11, 2024
Current implementation of `AppendDimensionString` ignores value `-1`. This PR fixes the bug. --------- Co-authored-by: ygorshkov <yury.gorshkov@wartsila.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of
AppendDimensionStringignores value-1.This PR fixes the bug.