Fix msbuild warnings, re-enable and treat all as errors #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a lot of doc! Looks good! Good to keep errors as warnings on IMHO. |
tmilnthorp
approved these changes
Feb 26, 2019
|
I agree and for a small library it's absolutely feasible to do. |
|
Just realized it's not turned on for WRC |
|
Yeah I don't want to touch those anymore really unless I have to |
|
Understandable 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495 .
This PR fixes several thousands of warnings. Left WRC projects alone as-is.
Moving forward, all public types/members should have xmldoc and this PR helps enforce that.
<NoWarn>from projects to unmute