Replace PowerShell codegen with C# #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was stepping on the toes of the new codegen and WRC should not generate test code anyhow.
|
Updated the WRC scripts too. |
tmilnthorp
approved these changes
Apr 30, 2019
|
Looks good to me! I'll have to pull the code and play with it when I get come time. |
Merge conflict had to be ported from PowerShell to C#. UnitAbbreviationsCache now gets single entries with string arrays instead of multiple entries with single item arrays. This is an improvement, but should be functionally equivalent.
|
Thanks, I'll merge this now and we can always refine it later. |
vKaras1337
added a commit
to vKaras1337/UnitsNet
that referenced
this pull request
Jun 28, 2023
…eGen change? can't find it because it looks like that this line changes has been excluded from commits from atleast (angularsen#656)
angularsen
pushed a commit
to vKaras1337/UnitsNet
that referenced
this pull request
Jul 11, 2023
…eGen change? can't find it because it looks like that this line changes has been excluded from commits from atleast (angularsen#656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522 .
I've looked into some alternatives in #522 and found that plain old C# should do they job just nicely.
dotnet runsupportdotnet-suggestsupport (experimental via DragonFruit package, but Summer Is Coming)The only downside I can think of is a slightly more cumbersome syntax, but it's really not much and tried to mitigate that with some helper methods.
Changes
/CodeGen.NET Core 2.1 console appThe new codegen produces pretty much identical output, except for a few whitespace improvements.
See the README for more info.