Add AbbreviatedUnitsConverter for Json.NET #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. with tests based on the SerializationTestsBase - no change to the DefaultDataContractJsonSerializerTests: only added Serializataion/Deserialization #regions
- added two tests ensuring the compatibility with a PlainOldQuantity (JsonObject)
|
I'm getting around to this one, soon. |
angularsen
requested changes
Nov 16, 2021
| } | ||
|
|
||
| [Fact] | ||
| public void DoubleQuantity_InScientificNotation_SerializedWithExpandedValueAndAbbreviatedUnit() |
There was a problem hiding this comment.
I'm not sure what this test verifies on our JsonNet serialization implementation?
Scientific notation on the ctor argument is simply a regular double so I believe this tests pretty much overlaps with DoubleQuantity_SerializedWithDoubleValueAndAbbreviatedUnit.
There was a problem hiding this comment.
The same tests exist in DataContractSerializerTests and DefaultDataContractJsonSerializerTests. I think I'll remove them there as well.
I'm surprised that I couldn't find the inverse set of tests - but from memory, both DC & JsonNet also support 1E+9 as input.
UnitsNet.Serialization.JsonNet.Tests/AbbreviatedUnitsConverterTests.cs
Outdated
Show resolved
Hide resolved
UnitsNet.Serialization.JsonNet.Tests/AbbreviatedUnitsConverterTests.cs
Outdated
Show resolved
Hide resolved
…ndedValueAndAbbreviatedUnit - added a test for Mbar/mbar: DoubleIQuantity_DeserializedFromDoubleValueAndAbbreviatedUnit_CaseSensitiveUnits - added an example to AbbreviatedUnitsConverter xml doc
angularsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. with tests based on the SerializationTestsBase
With the default settings matches all properties and values using the StringComparer.OrdinalIgnoreCase comparer (as is the default JsonNet matching strategy).
It is possible to customize the 'known types' information (defaults to
Quantity.ByName) - however don't expect to have out of the box handling forHowMuchjust yet - we're still dependent on the switch inQuantity.From(we should maybe consider introducing construction methods into QuantityInfo sub-classes or something).I managed to get the decimals working with manually operating the reader (not without a few hurtles).
Finally, another break from the original serialization converters (but consistent with the DataContract / protobuf) is handling of the default types (instead of throwing an exception when no value is provided).
PS I haven't added any handling for EmitDefaultValues = false (I assume there is one such option somewhere in JsonNet) - but I think that's hardly necessary (if we want it- we should discuss the 'default' behavior of the
Typeproperty)