Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Insights Provider #83

Merged
merged 9 commits into from
Dec 14, 2016
Merged

App Insights Provider #83

merged 9 commits into from
Dec 14, 2016

Conversation

hikirsch
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    Application Insights provider  #40

  • What is the new behavior (if this is a feature change)?
    Feature was implemented with tests.

  • Other information:

@hikirsch
Copy link
Contributor Author

hikirsch commented Dec 12, 2016

@JonnyBGod i have no idea why this build is failing. any ideas?

@JonnyBGod
Copy link
Collaborator

It is strange indeed. It passes all tests locally. Seams like a problem with travis.

@hikirsch
Copy link
Contributor Author

i wonder if it's the version of chrome, we're on version 55 and it seems from the travis output its on version 37.

@JonnyBGod
Copy link
Collaborator

angular/angular#13301

@JonnyBGod
Copy link
Collaborator

Would you mind waiting a few days for their fix to be release?

@hikirsch
Copy link
Contributor Author

no problem. thanks!

@JonnyBGod JonnyBGod merged commit 322b21e into angulartics:master Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants