Skip to content

Commit

Permalink
[PATCH] lose the unused file argument in generic_ide_ioctl()
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Oct 21, 2008
1 parent 74f3c8a commit 1bddd9e
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion drivers/ide/ide-cd.c
Original file line number Diff line number Diff line change
Expand Up @@ -2174,7 +2174,7 @@ static int idecd_ioctl(struct inode *inode, struct file *file,
break;
}

err = generic_ide_ioctl(info->drive, file, bdev, cmd, arg);
err = generic_ide_ioctl(info->drive, bdev, cmd, arg);
if (err == -EINVAL)
err = cdrom_ioctl(file, &info->devinfo, inode, cmd, arg);

Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/ide-disk_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ int ide_disk_ioctl(ide_drive_t *drive, struct inode *inode, struct file *file,
if (err != -EOPNOTSUPP)
return err;

return generic_ide_ioctl(drive, file, bdev, cmd, arg);
return generic_ide_ioctl(drive, bdev, cmd, arg);
}
2 changes: 1 addition & 1 deletion drivers/ide/ide-floppy_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ int ide_floppy_ioctl(ide_drive_t *drive, struct inode *inode,
file ? file->f_mode : 0, cmd, argp);

if (err == -ENOTTY)
err = generic_ide_ioctl(drive, file, bdev, cmd, arg);
err = generic_ide_ioctl(drive, bdev, cmd, arg);

return err;
}
3 changes: 1 addition & 2 deletions drivers/ide/ide-ioctls.c
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,7 @@ static int generic_drive_reset(ide_drive_t *drive)
return ret;
}

int generic_ide_ioctl(ide_drive_t *drive, struct file *file,
struct block_device *bdev,
int generic_ide_ioctl(ide_drive_t *drive, struct block_device *bdev,
unsigned int cmd, unsigned long arg)
{
int err;
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/ide-tape.c
Original file line number Diff line number Diff line change
Expand Up @@ -2368,7 +2368,7 @@ static int idetape_ioctl(struct inode *inode, struct file *file,
struct block_device *bdev = inode->i_bdev;
struct ide_tape_obj *tape = ide_drv_g(bdev->bd_disk, ide_tape_obj);
ide_drive_t *drive = tape->drive;
int err = generic_ide_ioctl(drive, file, bdev, cmd, arg);
int err = generic_ide_ioctl(drive, bdev, cmd, arg);
if (err == -EINVAL)
err = idetape_blkdev_ioctl(drive, cmd, arg);
return err;
Expand Down
2 changes: 1 addition & 1 deletion drivers/scsi/ide-scsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ static int idescsi_ide_ioctl(struct inode *inode, struct file *file,
{
struct block_device *bdev = inode->i_bdev;
struct ide_scsi_obj *scsi = ide_scsi_g(bdev->bd_disk);
return generic_ide_ioctl(scsi->drive, file, bdev, cmd, arg);
return generic_ide_ioctl(scsi->drive, bdev, cmd, arg);
}

static struct block_device_operations idescsi_ops = {
Expand Down
3 changes: 1 addition & 2 deletions include/linux/ide.h
Original file line number Diff line number Diff line change
Expand Up @@ -1158,8 +1158,7 @@ struct ide_ioctl_devset {
int ide_setting_ioctl(ide_drive_t *, struct block_device *, unsigned int,
unsigned long, const struct ide_ioctl_devset *);

int generic_ide_ioctl(ide_drive_t *, struct file *, struct block_device *,
unsigned, unsigned long);
int generic_ide_ioctl(ide_drive_t *, struct block_device *, unsigned, unsigned long);

extern int ide_vlb_clk;
extern int ide_pci_clk;
Expand Down

0 comments on commit 1bddd9e

Please sign in to comment.