Skip to content

Commit

Permalink
i2c: bcm2835: Use dev_dbg logging on transfer errors
Browse files Browse the repository at this point in the history
Writing to an AT24C32 generates on average 2x i2c transfer errors per
32-byte page write. Which amounts to a lot for a 4k write. This is due
to the fact that the chip doesn't respond during it's internal write
cycle when the at24 driver tries and retries the next write.
Only a handful drivers use dev_err() on transfer error, so switch to
dev_dbg() instead.

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
  • Loading branch information
notro authored and Wolfram Sang committed Nov 7, 2016
1 parent d4030d7 commit 23c9540
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/i2c/busses/i2c-bcm2835.c
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ static int bcm2835_i2c_xfer_msg(struct bcm2835_i2c_dev *i2c_dev,
(msg->flags & I2C_M_IGNORE_NAK))
return 0;

dev_err(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err);
dev_dbg(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err);

if (i2c_dev->msg_err & BCM2835_I2C_S_ERR)
return -EREMOTEIO;
Expand Down

0 comments on commit 23c9540

Please sign in to comment.