forked from raspberrypi/linux
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vc4: possible memleak in vc4_hdmi_connector_get_modes #101
Comments
It seems that a similiar leak is there in linux-next-20170807 (RPI3 32bit):
|
Yeah, need to kfree(edid) |
Fixed in drm-misc-next |
Lyude
pushed a commit
to Lyude/linux
that referenced
this issue
Oct 11, 2017
We don't keep a pointer to it around anywhere, so it's our job to free it. Cc: Stefan Wahren <stefan.wahren@i2se.com> Link: anholt/linux#101 Fixes: c8b75bc ("drm/vc4: Add KMS support for Raspberry Pi.") Signed-off-by: Eric Anholt <eric@anholt.net> Link: https://patchwork.freedesktop.org/patch/msgid/20170808205605.4432-1-eric@anholt.net Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
anholt
added a commit
that referenced
this issue
Nov 13, 2017
We don't keep a pointer to it around anywhere, so it's our job to free it. Cc: Stefan Wahren <stefan.wahren@i2se.com> Link: #101 Fixes: c8b75bc ("drm/vc4: Add KMS support for Raspberry Pi.") Signed-off-by: Eric Anholt <eric@anholt.net> Link: https://patchwork.freedesktop.org/patch/msgid/20170808205605.4432-1-eric@anholt.net Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Tested-by: Stefan Wahren <stefan.wahren@i2se.com> (cherry picked from commit 5afe0e6)
anholt
added a commit
that referenced
this issue
Nov 21, 2017
We don't keep a pointer to it around anywhere, so it's our job to free it. Cc: Stefan Wahren <stefan.wahren@i2se.com> Link: #101 Fixes: c8b75bc ("drm/vc4: Add KMS support for Raspberry Pi.") Signed-off-by: Eric Anholt <eric@anholt.net> Link: https://patchwork.freedesktop.org/patch/msgid/20170808205605.4432-1-eric@anholt.net Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Tested-by: Stefan Wahren <stefan.wahren@i2se.com> (cherry picked from commit 5afe0e6)
popcornmix
pushed a commit
to raspberrypi/linux
that referenced
this issue
Feb 6, 2018
We don't keep a pointer to it around anywhere, so it's our job to free it. Cc: Stefan Wahren <stefan.wahren@i2se.com> Link: anholt#101 Fixes: c8b75bc ("drm/vc4: Add KMS support for Raspberry Pi.") Signed-off-by: Eric Anholt <eric@anholt.net> Link: https://patchwork.freedesktop.org/patch/msgid/20170808205605.4432-1-eric@anholt.net Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Tested-by: Stefan Wahren <stefan.wahren@i2se.com> (cherry picked from commit 5afe0e6)
johalun
pushed a commit
to FreeBSDDesktop/kms-drm
that referenced
this issue
Mar 23, 2018
We don't keep a pointer to it around anywhere, so it's our job to free it. Cc: Stefan Wahren <stefan.wahren@i2se.com> Link: anholt/linux#101 Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.") Signed-off-by: Eric Anholt <eric@anholt.net> Link: https://patchwork.freedesktop.org/patch/msgid/20170808205605.4432-1-eric@anholt.net Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
raspbian-autopush
pushed a commit
to raspbian-packages/linux-4.9
that referenced
this issue
Apr 7, 2018
commit 81d8808 Author: Eric Anholt <eric@anholt.net> Date: Tue Aug 8 13:56:05 2017 -0700 drm/vc4: Fix leak of HDMI EDID We don't keep a pointer to it around anywhere, so it's our job to free it. Cc: Stefan Wahren <stefan.wahren@i2se.com> Link: anholt/linux#101 Fixes: c8b75bc ("drm/vc4: Add KMS support for Raspberry Pi.") Signed-off-by: Eric Anholt <eric@anholt.net> Link: https://patchwork.freedesktop.org/patch/msgid/20170808205605.4432-1-eric@anholt.net Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Tested-by: Stefan Wahren <stefan.wahren@i2se.com> (cherry picked from commit 5afe0e62a548a0aa7d2095a98530b68f3d2c64e6) Gbp-Pq: Topic rpi Gbp-Pq: Name rpi_1461_81d8808b1b58d0cf750e641c20f7b5d32e975777.patch
raspbian-autopush
pushed a commit
to raspbian-packages/linux-4.9
that referenced
this issue
Nov 11, 2018
commit 81d8808 Author: Eric Anholt <eric@anholt.net> Date: Tue Aug 8 13:56:05 2017 -0700 drm/vc4: Fix leak of HDMI EDID We don't keep a pointer to it around anywhere, so it's our job to free it. Cc: Stefan Wahren <stefan.wahren@i2se.com> Link: anholt/linux#101 Fixes: c8b75bc ("drm/vc4: Add KMS support for Raspberry Pi.") Signed-off-by: Eric Anholt <eric@anholt.net> Link: https://patchwork.freedesktop.org/patch/msgid/20170808205605.4432-1-eric@anholt.net Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Tested-by: Stefan Wahren <stefan.wahren@i2se.com> (cherry picked from commit 5afe0e62a548a0aa7d2095a98530b68f3d2c64e6) Gbp-Pq: Topic rpi Gbp-Pq: Name rpi_1461_81d8808b1b58d0cf750e641c20f7b5d32e975777.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
i started my Raspberry Pi Zero W (4.13-rc1) without HDMI connected and after booting i connected HDMI. After some delay the kmemleak reported the following:
The text was updated successfully, but these errors were encountered: