-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced-Motion: Replace animation: unset and transition: none with 0-length durations. #931
Conversation
…otion Update _base.css
@sivot that's not a full fix, setting animations to unset/none with !important can still break websites for those with animations disabled with no good way of overriding it. That's an unacceptable solution if you ask me. |
K |
It's okay, if that break the animations in only cases below:
In any other cases the animations need to work...Testing:
|
You don't get the issue here, the issue is not that animations don't do their thing doing their thing, that's exactly what we expect, which is what 0-duration animations do as well. The problem is that setting animations/transitions to unset/none can break functionality of websites, and not just the appearance of animations, this is not acceptable. We don't want people with animations disabled to not be able to use the site because a library has been careless. For example (a real example) you could have a sliding menu, and its visibility is done purely with animations, with duration 0, toggling the menu will just make it just appear/disappear instantly without an animation, with animations completely removed with unset/none, the menu will forever be at open/closed state depending on how it's made, and therefore actually broken. |
@shpuld right. Sorry. ;) |
This seems a solid solution and will get merged. I'll do this as soon as I have a little more free time as this will need a new release. |
@shpuld I think there will be a little trouble with Otherwise the solution tested, it works fine. Good job. |
Hmm, I hadn't thought about that, gotta investigate and try it out I suppose |
@shpuld On IOS animation js events (like |
Thanks @sivot , I'll do that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works fine.
any update @eltonmesquita ? would be nice to get this upstream |
Sorry for the long delay, but I was on a tight schedule. Anyway, I had to do my research to be sure what was the best solution. As @sivot noted the current PR is indeed the best case scenario, although it feels a bit hacky. I'll merge it and release the new version. Thanks for the PR @shpuld . |
Thanks a lot, it fixed my problems with animations not loading at all in any browser. Apparently when I formated my Pc I turned off everything in W10. |
This way motion is still reduced and functionality that depends on animations/transitions doesn't break.