Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from upstream repo #2

Merged
merged 73 commits into from
Feb 4, 2022
Merged

Update from upstream repo #2

merged 73 commits into from
Feb 4, 2022

Conversation

themichaelyan
Copy link

@themichaelyan themichaelyan commented Feb 3, 2022

This is blocking ruby 3 upgrade in client service, so I just updated the pact-ruby to latest version from upstream and still keep the changes from Ali.
Tested, the updated branch works for client_service unit test.

bethesque and others added 30 commits February 21, 2019 19:46
Do not pretty print a JSON object when serialization or serialization fail, for details see pact-foundation#103.
feat: improve logging robustness for non utf-8 characters
…kip-writing-pact

Support not writing interactions to pact file if marked
bethesque and others added 27 commits March 14, 2020 19:18
Co-authored-by: Lindsey Hattamer <lindsey.hattamer@oddball.io>

Co-authored-by: Lindsey Hattamer <lindsey.hattamer@oddball.io>
…ndation#128)

Co-authored-by: Matthew Hall <matthew.hall@partnerize.com>
@themichaelyan themichaelyan requested a review from aliking February 3, 2022 22:50
Copy link
Collaborator

@aliking aliking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. Seems good if this works

@themichaelyan themichaelyan merged commit 36f20f0 into master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.