Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated from upstream repo #6

Merged
merged 165 commits into from
Feb 4, 2022
Merged

Updated from upstream repo #6

merged 165 commits into from
Feb 4, 2022

Conversation

themichaelyan
Copy link

@themichaelyan themichaelyan commented Feb 3, 2022

This is blocking ruby 3 upgrade in client service, so I just updated the pact-ruby to latest version from upstream and still keep the changes from Ali.

Tested, the updated branch works for client_service unit test.

bethesque and others added 30 commits February 11, 2019 10:38
feat: add support for bearer token authentication to the broker
…JSON when used in conjuction with other libraries (eg. Oj)
…r the pact-ruby-standalone. Drop 2.4 and 2.5, and just do 2.6, as the inbetween versions should be fine
bethesque and others added 27 commits January 22, 2021 08:50
…ing the environment variable PACT_DISABLE_SSL_VERIFICATION=true
@themichaelyan themichaelyan requested a review from aliking February 3, 2022 22:48
Copy link
Collaborator

@aliking aliking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had a bit of look at the failing tests and they seem to be either mocks not working or checks that are different because of our customizations

@themichaelyan themichaelyan merged commit dd58f7e into master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.