forked from pact-foundation/pact-ruby
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated from upstream repo #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add support for bearer token authentication to the broker
…JSON when used in conjuction with other libraries (eg. Oj)
…ling Ruby for the pact-ruby-standalone
…r the pact-ruby-standalone. Drop 2.4 and 2.5, and just do 2.6, as the inbetween versions should be fine
…ntError to be raised when composing a URI For: pact-foundation/pact-net#289
…ing the environment variable PACT_DISABLE_SSL_VERIFICATION=true
…r version selectors
…' API when it is false
aliking
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I had a bit of look at the failing tests and they seem to be either mocks not working or checks that are different because of our customizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocking ruby 3 upgrade in client service, so I just updated the pact-ruby to latest version from upstream and still keep the changes from Ali.
Tested, the updated branch works for client_service unit test.