Wa 47 add hero #26
Merged
Wa 47 add hero #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiljaywarner
approved these changes
Jul 24, 2024
|
no, it should not be in gitignore (google it), i just did not expect
changes to it
we should add appcheck at some point, but not urgent bc no paid services.
…On Wed, Jul 24, 2024 at 4:55 PM David Allen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ios/Runner/GoogleService-Info.plist
<#26 (comment)>
:
> <key>API_KEY</key>
- <string>AIzaSyCIjs-8C_Fn7o8rXbfYI0KZSa5VKuxwbcA</string>
+ <string>AIzaSyCC0kY83Dkae-JerTEFc7rclmJ-T89wp2I</string>
oh, no. I should add this file to gitignore
—
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ2W5FDOVQIKEGBSNXBFZ3ZOAPFFAVCNFSM6AAAAABLNIG5A6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOJXHA2TSNJQGI>
.
You are receiving this because you are subscribed to this thread.Message
ID:
<anirac-tech/2024_black_tax_and_white_benefits/pull/26/review/2197859502@
github.com>
|
|
Looks cool, thanks for doing it |
|
It actually doesn't work right now because identical hero tags are being created for both the "favorites" page and the "stream" page. Not sure the best way to handle this yet |
|
ok i guess
as long as it works for new devs
…On Wed, Jul 24, 2024 at 4:59 PM David Allen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ios/Runner/GoogleService-Info.plist
<#26 (comment)>
:
> <key>API_KEY</key>
- <string>AIzaSyCIjs-8C_Fn7o8rXbfYI0KZSa5VKuxwbcA</string>
+ <string>AIzaSyCC0kY83Dkae-JerTEFc7rclmJ-T89wp2I</string>
I think it should probably be in gitignore because we have a run script
for iOS that copies the correct GoogleService-Info.plist into this location
whenever the app builds.
—
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXBGYKLUMAC6MLODD6LEJDZOAPVLAVCNFSM6AAAAABLNIG5A6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOJXHA3DIMZWG4>
.
You are receiving this because your review was requested.Message ID:
<anirac-tech/2024_black_tax_and_white_benefits/pull/26/review/2197864367@
github.com>
|
|
could you just call them hero_whatever_1 and stream_whatever_1?
…On Wed, Jul 24, 2024 at 5:03 PM David Allen ***@***.***> wrote:
It actually doesn't work right now because identical hero tags are being
created for both the "favorites" page and the "stream" page. Not sure the
best way to handle this yet
—
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXBGYKAIDM4Y3W2NTJQTUTZOAQEXAVCNFSM6AAAAABLNIG5A6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYHE3TGOBZG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***
com>
|
|
@alexdivadi plz consider moving forward with this soon after the contest submission, possibly with Trey C's thumbusp/user acceptance testing if you two have time to do that within a few days or a week or so. thanks |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screen.Recording.2024-07-24.at.2.05.36.PM.mov
Type of Change