Added onclick configuration option, event handler/dispatcher and rele… #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vant documentation in README.md
| // Handle User-Defined onclick event, if defined | ||
| if(widget.config.hasOwnProperty('onclick')) { | ||
| widget.config.onclick(hotspot) | ||
| } |
There was a problem hiding this comment.
@RogerWebb It's a nice feature to have. But what's the plan for spot_html element when onclick is defined in the widget config. I think it should also get handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a simple "onclick" event dispatcher. README.md has an example (#4 under Key Features), demonstrating it's use. Please let me know if you have any questions or concerns with the PR. I think there are more people like myself that may find it useful and I may have another idea or two to contribute if you're interested in merging.
Cheers!
Roger