Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyScss version to fix local dev #82

Conversation

ajyong
Copy link
Contributor

@ajyong ajyong commented Apr 19, 2020

I was following DEVELOPMENT.md and using the Vagrant route but ran into a pip install error:

Collecting psycopg2==2.8.4
  Using cached psycopg2-2.8.4.tar.gz (377 kB)
Collecting pyScss==1.3.5
  Using cached pyScss-1.3.5.tar.gz (123 kB)
    ERROR: Command errored out with exit status 1:
     command: /gavel/env/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-d3yyy60h/pyScss/setup.py'"'"'; __file__='"'"'/tmp/pip-install-d3yyy60h/pyScss/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-d3yyy60h/pyScss/pip-egg-info
         cwd: /tmp/pip-install-d3yyy60h/pyScss/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-d3yyy60h/pyScss/setup.py", line 9, in <module>
        from setuptools import setup, Extension, Feature
    ImportError: cannot import name 'Feature' from 'setuptools' (/gavel/env/lib/python3.7/site-packages/setuptools/__init__.py)
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Apparently this was an intended change by PyPA, but I don't understand why they did not clean up their __init__.py.

Because downgrading the setuptools given to me by virtualenv felt wrong, I opted to instead bump pyScss up two minor versions from 1.3.5 to 1.3.7.

I think this is including a commit you made in master that doesn't exist in develop. Let me know if I'm PRing into the right branch. Thank you!

anishathalye and others added 2 commits February 29, 2020 09:34
- Following DEVELOPMENT.md's Vagrant steps results in setuptools 46.x to be installed
- This new version completely removes "Feature" from __init__.py, resulting in an error
@anishathalye
Copy link
Owner

Merged in 9f4454c. Thank you!

@ajyong ajyong deleted the bump-pyscss-version-to-fix-local-dev branch April 20, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants