Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#84 test cases for get personal background api #85

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Issue#84 test cases for get personal background api #85

merged 2 commits into from
Aug 11, 2020

Conversation

mtreacy002
Copy link
Member

Description

Test cases for POST and GET /user/personal_background api endpoints.

Fixes #84

Type of Change:

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

By running tests on VSCode Tests Explorer and python unittest with result all tests passed.
Screen Shot 2020-07-16 at 10 07 35 pm

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@mtreacy002 mtreacy002 requested review from ramitsawhney27 and a team July 16, 2020 12:14
@mtreacy002 mtreacy002 self-assigned this Jul 16, 2020
@mtreacy002 mtreacy002 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jul 16, 2020
@mtreacy002 mtreacy002 added this to the GSoc Coding Phase 2 milestone Jul 16, 2020
@mtreacy002
Copy link
Member Author

Update @anitab-org/bridgeintech-maintainers . Here's the test cases for the POST and GET /user/perrsonal_background api endpoints (PR #82 ). Please review when you have time. Ta

@mtreacy002 mtreacy002 force-pushed the issue#84-test-cases-for-post-get-personal-background-api branch from 46b9da7 to c96d6f2 Compare July 18, 2020 13:24
ramitsawhney27
ramitsawhney27 previously approved these changes Jul 19, 2020
View reviewed changes
@mtreacy002 mtreacy002 added the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label Jul 19, 2020
@mtreacy002 mtreacy002 changed the title Issue#84 test cases for post get personal background api WIP | Issue#84 test cases for post get personal background api Jul 19, 2020
@mtreacy002 mtreacy002 force-pushed the issue#84-test-cases-for-post-get-personal-background-api branch from c96d6f2 to 1fa501a Compare July 22, 2020 07:30
@mtreacy002 mtreacy002 changed the title WIP | Issue#84 test cases for post get personal background api Issue#84 test cases for post get personal background api Jul 22, 2020
@mtreacy002 mtreacy002 requested review from ramitsawhney27 and a team July 22, 2020 07:32
@mtreacy002 mtreacy002 removed the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label Jul 22, 2020
@mtreacy002
Copy link
Member Author

Update @anitab-org/bridgeintech-maintainers . I've made the changes to Background enum logic as discussed on our BIT weekly meeting. Please re-review when you have time. Thanks

@mtreacy002 mtreacy002 force-pushed the issue#84-test-cases-for-post-get-personal-background-api branch from 1fa501a to 6602d67 Compare July 22, 2020 14:01
@mtreacy002
Copy link
Member Author

Update @anitab-org/bridgeintech-maintainers . I've just force pushed changes to add other fields for physical and mental ability as well as socio-economic status

@mtreacy002 mtreacy002 force-pushed the issue#84-test-cases-for-post-get-personal-background-api branch from 6602d67 to fadd717 Compare July 26, 2020 07:51
@mtreacy002
Copy link
Member Author

Update @anitab-org/bridgeintech-maintainers . I've resolved merge conflict and pull rebase changes from PR #80 and #82 on bugs fixes. Please check this out when you have time, thanks

ramitsawhney27
ramitsawhney27 previously approved these changes Jul 29, 2020
View reviewed changes
Copy link

@ramitsawhney27 ramitsawhney27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revisions look fine to me

@foongminwong
Copy link

@mtreacy002 review the following conflicting files when you have time 👍

@mtreacy002
Copy link
Member Author

@mtreacy002 review the following conflicting files when you have time 👍

Will do that now, @foongminwong 😉

@mtreacy002 mtreacy002 force-pushed the issue#84-test-cases-for-post-get-personal-background-api branch from fadd717 to decbf6e Compare August 1, 2020 12:21
@mtreacy002
Copy link
Member Author

@foongminwong and @ramitsawhney27 I've just resolved the merge conflict and force pushed the changes. Can you please approve and merge this PR? Thanks

foongminwong
foongminwong previously approved these changes Aug 1, 2020
View reviewed changes
Copy link

@foongminwong foongminwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

test-pr-85

ramitsawhney27
ramitsawhney27 previously approved these changes Aug 1, 2020
View reviewed changes
@mtreacy002
Copy link
Member Author

Update @anitab-org/bridgeintech-maintainers. From this PR to thee next in queue, I need to refactor POST/PUT so, please DO NOT MERGE this one till I complete refactoring. Ta

@mtreacy002 mtreacy002 changed the title Issue#84 test cases for post get personal background api Issue#84 test cases for post get personal background api [DO NOT MERGE] Aug 3, 2020
@mtreacy002 mtreacy002 added the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label Aug 3, 2020
@mtreacy002 mtreacy002 dismissed stale reviews from ramitsawhney27 and foongminwong via 453f1a9 August 3, 2020 12:46
@mtreacy002 mtreacy002 force-pushed the issue#84-test-cases-for-post-get-personal-background-api branch from decbf6e to 453f1a9 Compare August 3, 2020 12:46
@mtreacy002
Copy link
Member Author

Update @anitab-org/bridgeintech-maintainers . I've removed POST /user/personal_background and test create personal background from this PR as the POST is no longer used as API as per our discussion. Please note that this PR is blocked by PR #101

@mtreacy002 mtreacy002 changed the title Issue#84 test cases for post get personal background api [DO NOT MERGE] Issue#84 test cases for post get personal background api Aug 3, 2020
@mtreacy002 mtreacy002 changed the title Issue#84 test cases for post get personal background api Issue#84 test cases for get personal background api Aug 3, 2020
@mtreacy002 mtreacy002 removed the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label Aug 3, 2020
@mtreacy002 mtreacy002 force-pushed the issue#84-test-cases-for-post-get-personal-background-api branch 2 times, most recently from 3ce0bf7 to f5a59df Compare August 3, 2020 13:09
ramitsawhney27
ramitsawhney27 previously approved these changes Aug 10, 2020
View reviewed changes
@mtreacy002
Feat: refactor Create Update user additional info to one api endpoint
35bafbb 
Fix bug on testing

fix typo requests.put mock patch

Remove POST user/personal_background

Remove Create personal background dao
@mtreacy002
Feat: Test cases for POST and GET /user/personal_background api endpo…
c0c12d0 
…ints

Refactored Background enum logic

Refactor test to include other fields for physical, mental ability and socio economic

Remove POST api endpoint for create user personal background

Remove Create personal background dao
@mtreacy002 mtreacy002 force-pushed the issue#84-test-cases-for-post-get-personal-background-api branch from f5a59df to c0c12d0 Compare August 10, 2020 23:52
@mtreacy002
Copy link
Member Author

Update @ramitsawhney27 and @anitab-org/bridgeintech-maintainers . I've resolved the merge conflict on this PR. can you please continue with the merging? Thanks

@mtreacy002 mtreacy002 mentioned this pull request Aug 11, 2020
Merged
5 tasks
@mtreacy002
Copy link
Member Author

@ramitsawhney27 , can you please re-approve this PR so it can be merged? Thanks

@ramitsawhney27 ramitsawhney27 merged commit b4e5c1c into anitab-org:develop Aug 11, 2020
@mtreacy002 mtreacy002 deleted the issue#84-test-cases-for-post-get-personal-background-api branch August 30, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramitsawhney27 ramitsawhney27 ramitsawhney27 approved these changes

@foongminwong foongminwong foongminwong approved these changes

Assignees

@mtreacy002 mtreacy002

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Milestone
GSoc Coding Phase 2
Development

Successfully merging this pull request may close these issues.

Dev: Test cases for POST and GET /user/personal_background
3 participants
@mtreacy002 @foongminwong @ramitsawhney27