Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: Current Relation screen #796

Closed
anna4j opened this issue Aug 30, 2020 · 16 comments
Closed

Redesign: Current Relation screen #796

anna4j opened this issue Aug 30, 2020 · 16 comments
Assignees
Labels
Category: User Interface Improvements or additions to design.

Comments

@anna4j
Copy link

anna4j commented Aug 30, 2020

Provide a re-design of the Current Relation screen (when the user has no relation and when the user has relation)

TIP: You can download the apk from here and play around with the app, to understand what elements we want in this screen.

Kindly follow the AnitaB.org Branding Guidelines

Describe the solution you'd like
Submission format: png / jpeg / Figma URL
In the PR add 1 image of the design to /docs/ui folder.

@anna4j anna4j added Category: User Interface Improvements or additions to design. Open Source Hack Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Aug 30, 2020
@SHITIZ-AGGARWAL
Copy link
Contributor

Hello @anna4j , since OSH has begun, I would like to work on this issue
I am new to open source so please guide me
Really excited to work with the organisation

@vj-codes
Copy link
Member

@SHITIZ-AGGARWAL assigning you .
Happy designing!

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Aug 31, 2020
@SHITIZ-AGGARWAL
Copy link
Contributor

thanks a lot

@SHITIZ-AGGARWAL
Copy link
Contributor

@anna4j @vj-codes I have completed my design but I am not able to find docs/ui folder , please help me

@vj-codes
Copy link
Member

vj-codes commented Sep 1, 2020

@SHITIZ-AGGARWAL right you need to create a the docs and ui folder and then update accordingly.

@vj-codes
Copy link
Member

vj-codes commented Sep 1, 2020

@anna4j is it possible that some manager/maintainer creates the docs and respective folder and get it merged by this week.
The contributors will be creating a new folders in each PR and by the end of the month while merging would it be a problem or not?
What say?

@SHITIZ-AGGARWAL
Copy link
Contributor

@vj-codes so should I wait for updates

@anna4j
Copy link
Author

anna4j commented Sep 1, 2020

@vj-codes so should I wait for updates

@SHITIZ-AGGARWAL no don't wait. As of now create docs folder and ui folder inside it.

@anna4j
Copy link
Author

anna4j commented Sep 1, 2020

@anna4j is it possible that some manager/maintainer creates the docs and respective folder and get it merged by this week.
The contributors will be creating a new folders in each PR and by the end of the month while merging would it be a problem or not?
What say?

Ya @vj-codes I agree. Let's raise this on Zulip and on Mentorship Android weekly osh meeting if it's not created by then

@vj-codes
Copy link
Member

vj-codes commented Sep 1, 2020

@anna4j I'm not a OSH mentor to attend the meeting we have our project managers meeting on Sat, I guess it best to discuss on zulip:)

SHITIZ-AGGARWAL added a commit to SHITIZ-AGGARWAL/mentorship-android that referenced this issue Sep 1, 2020
@SHITIZ-AGGARWAL
Copy link
Contributor

@anna4j @vj-codes
please review this #820 ,if I uploaded the file correctly or not

@anna4j
Copy link
Author

anna4j commented Sep 1, 2020

@SHITIZ-AGGARWAL next time onwards write fixes[issue number] instead of "solving" in the PR description. Just follow the template :) This will link the PR to this issue

@SHITIZ-AGGARWAL
Copy link
Contributor

Sure , I will keep that in mind ,thanks a lot

@ashwinijha6
Copy link
Contributor

ashwinijha6 commented Sep 27, 2020

@vj-codes & @anna4j could u pls assign me this issue as I want to work on this as an osh participant

@ashwinijha6
Copy link
Contributor

@anna4j & @vj-codes I have made a pull request related to the issue pls review & let me know the changes

@vj-codes
Copy link
Member

vj-codes commented Mar 2, 2021

Closing as it was discussed to close all redesign UI related issues and PRs from OSH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: User Interface Improvements or additions to design.
Projects
None yet
5 participants