Skip to content

Infographic added #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Infographic added #902

wants to merge 6 commits into from

Conversation

sharur7
Copy link
Contributor

@sharur7 sharur7 commented Sep 14, 2020

Description

Added infographics for the mentorship system.

Fixes #858

Type of Change:

  • Outreach

How Has This Been Tested?

I read the wiki and researched the organization to complete the task.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

@sharur7
Copy link
Contributor Author

sharur7 commented Sep 14, 2020

@vj-codes Can you please review it? It's part of OSH

@vj-codes
Copy link
Member

@anna4j for this particular issue I see that the content and titles are same for all PRs. Is it supposed to be same since it's a UI issue or not? Do confirm and review , thanks!

@vj-codes vj-codes requested a review from anna4j September 14, 2020 14:40
@anna4j
Copy link

anna4j commented Sep 14, 2020

@anna4j for this particular issue I see that the content and titles are same for all PRs. Is it supposed to be same since it's a UI issue or not? Do confirm and review , thanks!

So if you see the issue description, the person who has created this issue has linked a wiki file and I suppose everyone has taken content from there. I think that should work

anna4j
anna4j previously approved these changes Sep 14, 2020
vj-codes
vj-codes previously approved these changes Sep 14, 2020
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thanks for your contribution @sharur7

@vj-codes vj-codes added the Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. label Sep 14, 2020
@vatsalkul
Copy link
Member

@sharur7 Looks great🎉

@sharur7 sharur7 dismissed stale reviews from vj-codes and anna4j via a12389d September 16, 2020 21:01
@rpattath rpattath added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels Nov 24, 2020
@isabelcosta
Copy link
Member

@sharur7 Thank you for your contribution and effort during OSH!

I will close this for now as this issue is not a priority and has to be furtherer discussed with Design members of the community. However, I added this PR to the OSH page in the Wiki 🤗 https://github.com/anitab-org/mentorship-android/wiki/OSH-September-2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

design: Infographic about mentorship system
6 participants