Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutReach/design: added Infographic about mentorship system #905

Closed
wants to merge 1 commit into from

Conversation

atharwa-24
Copy link
Contributor

@atharwa-24 atharwa-24 commented Sep 14, 2020

Description

created an infographic For Anitab-org
added the infographics link in /docs/ui/infographics.md

Fixes #858

Type of Change:

Delete irrelevant options.

  • Outreach

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

@atharwa-24
Copy link
Contributor Author

@vj-codes have a look on it!!!

@vj-codes vj-codes requested a review from anna4j September 14, 2020 18:43
Copy link

@anna4j anna4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really well designed and looks nice. But it doesn't align with the app design much. But again is that a factor we should consider? @vatsalkul since this is an infographic, should the color scheme and aesthetics align with the App Design
Please review this

@anna4j anna4j added the Status: Needs Review PR needs an additional review or a maintainer's review. label Sep 14, 2020
@vatsalkul
Copy link
Member

agreed with @anna4j
Try to use colors related to our project. and as you are submitting a pdf file then you can make the links clickable in pdf.

@anna4j anna4j added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Sep 21, 2020
@atharwa-24
Copy link
Contributor Author

@anna4j @vatsalkul I had made the changes in the infograph used the logo theme of the AnitaB.org. Added in the same folder.

@atharwa-24 atharwa-24 requested a review from anna4j September 22, 2020 05:22
@atharwa-24
Copy link
Contributor Author

@vj-codes review it once

@atharwa-24 atharwa-24 changed the title design: added Infographic about mentorship system OutReach/design: added Infographic about mentorship system Sep 22, 2020
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atharwa-24 can you please shift Mentorship System a bit to the right on android logo , so it's completely on the purple section .It's overlapping right now
Also if possible keep the same color for text throughout and titles in one section
example About the app and who it is created for can be either orange or green
Right now , there's no much emphasis on text and titles due to use of so many color variations
Just these minor changes and then you are done!

@atharwa-24 atharwa-24 requested a review from vj-codes September 22, 2020 09:26
@atharwa-24
Copy link
Contributor Author

@vj-codes made the changes could you plz review it again!!!

@vj-codes
Copy link
Member

@atharwa-24 yeah sure , which is the final one btw 3rd or 4th ?Please can remove the earlier ones

@atharwa-24
Copy link
Contributor Author

atharwa-24 commented Sep 28, 2020

@atharwa-24 yeah sure , which is the final one btw 3rd or 4th ?Please can remove the earlier ones

Done! @vj-codes @vatsalkul

@isabelcosta
Copy link
Member

@atharwa-24 Thank you for your contribution and effort during OSH!

I will close this for now as this issue is not a priority and has to be furtherer discussed with Design members of the community. However, I added this PR to the OSH page in the Wiki 🤗 https://github.com/anitab-org/mentorship-android/wiki/OSH-September-2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

design: Infographic about mentorship system
5 participants