Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign of the Request Detail Screen #920

Closed
wants to merge 1 commit into from
Closed

Redesign of the Request Detail Screen #920

wants to merge 1 commit into from

Conversation

Anmollenka
Copy link
Contributor

@Anmollenka Anmollenka commented Sep 17, 2020 •
edited
Loading

Description

This is a redesign of the Request Detail Screen .

Fixes #808

Type of Change:

  • User Interface

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)

iofall
iofall suggested changes Sep 17, 2020
View reviewed changes
Copy link

@iofall iofall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Anmollenka. Could you please make the following changes:

  1. Remove the shadows from the text (Notes). Also reduce the shadows for the boxes.
  2. Fix the arrow next to Request Detail in the top bar. The one we currently have in the app would look better.
  3. Please align everything properly, for example, To String, the Profile Picture circle and the Notes box should be aligned in the same line.
  4. For the Profile Picture Circle, maybe try this one from the Member Profile Screen
    image
    and see if it looks better?

@Anmollenka
Copy link
Contributor Author

Okk @iofall I will make the required changes.

@Anmollenka
Copy link
Contributor Author

@iofall Can I use a photo in the circle for the profile picture.

@iofall
Copy link

iofall commented Sep 17, 2020

Yes that will work!

@sanchi0204 sanchi0204 added the Status: Changes Requested Changes are required to be done by the PR author. label Sep 17, 2020
@Anmollenka
Copy link
Contributor Author

@iofall I have made the required changes.

@Anmollenka
Copy link
Contributor Author

But I have removed the boxes as it was not looking good.

@Anmollenka
Copy link
Contributor Author

Please review it.Thank You.

iofall
iofall previously approved these changes Sep 18, 2020
View reviewed changes
Copy link

@iofall iofall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@iofall iofall added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Sep 18, 2020
@Anmollenka
Copy link
Contributor Author

@vj-codes @sanchi0204 Can you review this pr so that I can make any changes if required?Thank You.

sanchi0204
sanchi0204 previously approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@sanchi0204 sanchi0204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vj-codes
vj-codes previously approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@vj-codes vj-codes added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Sep 20, 2020
@Anmollenka
Copy link
Contributor Author

@vj-codes Shall I squash the commits so that this pull request can be merged?

@ravi5175
Copy link

@Anmollenka yes, you should always squash commit

@Anmollenka Anmollenka changed the title style : redesign Redesign of the Request Detail Screen Nov 14, 2020
@Anmollenka Anmollenka dismissed stale reviews from vj-codes, sanchi0204, and iofall via c7eb699 November 14, 2020 08:50
@vj-codes
Copy link
Member

@Anmollenka thank you for your contribution 🎉
This PR will be closed and your contribution will be noted on OSH September 2020 Wiki Page

@vj-codes vj-codes closed this Nov 19, 2020
@vj-codes vj-codes added Category: User Interface Improvements or additions to design. and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchi0204 sanchi0204 Awaiting requested review from sanchi0204

@vj-codes vj-codes Awaiting requested review from vj-codes

@iofall iofall Awaiting requested review from iofall

Assignees
No one assigned
Labels
Category: User Interface Improvements or additions to design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign: Request Detail screen
6 participants
@Anmollenka @iofall @ravi5175 @vj-codes @sanchi0204 @mayburgos