Skip to content

redesign: request detail #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

redesign: request detail #946

wants to merge 1 commit into from

Conversation

priyanshuone6
Copy link
Contributor

Description

Redesigned request detail screen
Added figma url in request_detail redesign.md to /docs/ui folder
Added request_detail redesign.png in to /docs/ui folder

Fixes #808

Type of Change:

Delete irrelevant options.

  • User Interface

Demo

request_detail redesign

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • Any dependent changes have been merged

sanchi0204
sanchi0204 approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@sanchi0204 sanchi0204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanchi0204 sanchi0204 added the Status: Needs Review PR needs an additional review or a maintainer's review. label Sep 21, 2020
@anna4j anna4j added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Sep 21, 2020
@vj-codes
Copy link
Member

@priyanshuone6 thank you for your contribution 🎉
This PR will be closed and your contribution will be noted on OSH September 2020 Wiki Page

@vj-codes vj-codes closed this Nov 19, 2020
@vj-codes vj-codes added Category: User Interface Improvements or additions to design. Open Source Hack and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@anna4j anna4j anna4j approved these changes

@sanchi0204 sanchi0204 sanchi0204 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Category: User Interface Improvements or additions to design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign: Request Detail screen
5 participants
@priyanshuone6 @vj-codes @anna4j @sanchi0204 @mayburgos