fix: Fixed tests running more than once and minor improvements #1095
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1095 +/- ##
===========================================
- Coverage 94.99% 94.75% -0.25%
===========================================
Files 38 37 -1
Lines 2058 2000 -58
===========================================
- Hits 1955 1895 -60
- Misses 103 105 +2
|
| @@ -26,30 +26,25 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python: [3.7, 3.9] | |||
| python: [3.7, 3.8, 3.9] | |||
There was a problem hiding this comment.
Don't think this is required please check on comment on vaishnavi's pr
There was a problem hiding this comment.
I added this because sometimes code blocks failed for particular software/library version. We should test each version that we provide support for.
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v1 | ||
| with: | ||
| file: ./coverage.xml | ||
| name: codecov-umbrella |
There was a problem hiding this comment.
Probably not related to this issue but upload coverage only if the maxtrix version is 3.7. Can you make this change too ?
There was a problem hiding this comment.
Do you want to upload coverage only when python version is 3.7?
If yes, then that can be done with a if block but why we need that?
There was a problem hiding this comment.
Do you want to upload coverage only when python version is 3.7?
If yes, then that can be done with a if block but why we need that?
Because it's uploading the coverage for both the versions.
There was a problem hiding this comment.
I think we should maintain coverage for all versions. May be in future we have some compatibility shims then coverage will change for versions
There was a problem hiding this comment.
I don't see how the python version is going to affect the coverage : /. Plus When the bot comments there is no way to differentiate between which coverage corresponds to which version.
There was a problem hiding this comment.
That was happening because all coverages have same name. Btw, I add a condition to upload coverage for Python 3.7
|
@devkapilbansal any updates here? ^ |
devkapilbansal
force-pushed
the
test-run-twice-fix
branch
from
eb475ea
to
044f902
Compare
devkapilbansal
force-pushed
the
test-run-twice-fix
branch
from
044f902
to
28987f2
Compare
devkapilbansal
added
the
Status: Needs Review
devkapilbansal
requested review from
a team,
aditmehta9 and
gaurivn
and removed request for
a team
devkapilbansal
force-pushed
the
test-run-twice-fix
branch
from
3aa3c87
to
7ee7793
Compare
Description
In github actions, checks were running multiple time unnecessarily.
Fixes #1093
Type of Change:
How Has This Been Tested?
Run in on my fork to ensure tests run only once and coverage report is generated too.
Checklist:
Code/Quality Assurance Only