-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot register a new user : Internal Server Error #1109
Comments
@isabelcosta I believe this has something to do with #1101 or previous merged commits , I think only you have access to fix it 👀 |
I tried it now using this data:
And I inspected and I got this error from Heroku console Click to expand!
cc @anitab-org/mentorship-maintainers I haven't had tome to look into this yet, but I think we can try to figure out from this log ^^ |
I remember opening a similar issue but closed it as I wasn't able to retrace it |
This is the error.
This is the statement. I think it's because the hash is overflowing the varchar limit. |
oh wow @epicadk so, it's a problem with the length set for the password field? |
Yep, atleast that's what I can infer from the logs. |
@isabelcosta @epicadk here it is #931 but it is different from this one 🤔 |
We tried again and can confirm the issue is still existing, and we have to adjust the limit of the So the problem here is that we have a limit for the password size, but we can't control the size of the hashing form of the password, so we are limiting it to 100 characters when often this hashing surpasses that value.
print from swagger with the error Next steps:
cc tested this w/ @vj-codes @devkapilbansal @ravi5175 |
I disagree. The length of the output of a hash function is constant. https://en.wikipedia.org/wiki/Cryptographic_hash_function#Properties |
@epicadk good point 👍🏾 I had that brief thought, but then seeing that the error is about the limit of the property, I saw removing/extending the limit as a potential solution. |
Yup extending seems like the way to go. I think the library we are using uses SHA256 by default. |
@epicadk that seems to be what I described in the follow-up issue. Is there anything I should correct there to not misguide contributors? |
Well the title is remove the limit, so that is a bit misleading. We should extend the limit instead so maybe you could update the title of the pr. |
Hello! |
Describe the bug
When I try to register a new user via the app or deployed Heroku link , Internal Server Error is found
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The new user should be registered successfully
The text was updated successfully, but these errors were encountered: