Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend password_hash limit from User data model #1137

Open
3 tasks
isabelcosta opened this issue Jul 24, 2021 · 12 comments
Open
3 tasks

Extend password_hash limit from User data model #1137

isabelcosta opened this issue Jul 24, 2021 · 12 comments
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Bug Bug or Bug fixes.

Comments

@isabelcosta
Copy link
Member

isabelcosta commented Jul 24, 2021

Description

As a developer,
I need to remove the limit for password_hash,
so that I can fix the registration endpoint, that is erroring 500 INTERNAL SERVER ERROR, because of the limit being reached.

This relates to fixing #1109

A comment that may help: #1109 (comment)

Mocks

print from swagger with the error

Acceptance Criteria

Update [Required]

  • Remove password_hash character limit

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

4h

@isabelcosta isabelcosta added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Bug Bug or Bug fixes. labels Jul 24, 2021
@isabelcosta
Copy link
Member Author

I would suggest setting a postgres SQL database, which is what we are using in the deployed server.
I am using https://elephantsql.com/ for it (so the contributor can too). Make sure to have this working with a database with the current state of the models, and only after you create and run the migration to alter/modify the column to not have a limit or have a bigger limit.

If any doubts you can ping me or @anitab-org/mentorship-maintainers and on Zulip => https://anitab-org.zulipchat.com/ 🤗

@epicadk
Copy link
Member

epicadk commented Jul 25, 2021

#1109 (comment)

@isabelcosta isabelcosta changed the title Remove password_hash limit from User data model Extend password_hash limit from User data model Jul 29, 2021
@isabelcosta
Copy link
Member Author

Thank you for your points @epicadk on #1109 I just changed the title ;)

@mridubhatnagar
Copy link

@isabelcosta I am a first-timer. I am interested in solving this issue, can you please assign it to me. :)

@vj-codes
Copy link
Member

Assigning you @mridubhatnagar
Happy coding!
And welcome to the community:)

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Aug 22, 2021
@mridubhatnagar
Copy link

@vj-codes @isabelcosta I have set up the project on my local system. Just wanted to understand how can I set up a database for the project?

@epicadk
Copy link
Member

epicadk commented Aug 23, 2021

@vj-codes @isabelcosta I have set up the project on my local system. Just wanted to understand how can I set up a database for the project?

It should automatically create a sqllite database.

@mridubhatnagar
Copy link

@vj-codes @isabelcosta I have set up the project on my local system. Just wanted to understand how can I set up a database for the project?

It should automatically create a sqllite database.

On my local system when I run the server. I am getting an error

sqlalchemy.exc.NoSuchModuleError: Can't load plugin: sqlalchemy.dialects:None
127.0.0.1 - - [23/Aug/2021 18:42:47] "GET /favicon.ico HTTP/1.1" 500 -

One of the possible reason the above errors comes is due to spelling mistake in the database name sqllite instead sqlite. I did cross check config.py to make sure spellings are correct. I could not find any mistake in file though. Not sure what could be other possible reason for the error.

@epicadk
Copy link
Member

epicadk commented Aug 23, 2021

Are you using docker or venv?

@mridubhatnagar
Copy link

Are you using docker or venv?

venv

@vj-codes
Copy link
Member

@mridubhatnagar I have linked the possible fixes on zulip:)

@mridubhatnagar
Copy link

@vj-codes responded to you on zulip. :)

@vj-codes vj-codes added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Bug Bug or Bug fixes.
Projects
None yet
Development

No branches or pull requests

4 participants