Enhancement: Use Enum Representation in Mentorship Relation

[devkapilbansal]

Description

I want to ensure that the database queries are fast and take less space for storage.

mentorship-backend/app/api/dao/mentorship_relation.py

Line 139 in 8924616

valid_states = ["PENDING", "ACCEPTED", "REJECTED", "CANCELLED", "COMPLETED"]

In the code above ☝️ , we are using string values for relation state which should be avoided.

Definition of Done

• All of the required items are completed.
• Approval by 1 mentor.

Estimation

5-6 hours

[msaini28r]

I would like to work on this issue. can you suggest me some hints?

[devkapilbansal]

Sure @msaini0r

Here, you will have to use numerical mapping of values with valid_states. Currently, we are storing string values that should be converted to 0,1,2... to save space

Check this file to have a clear idea of what is needed 👇
https://github.com/anitab-org/mentorship-backend/blob/develop/app/utils/enum_utils.py

[vj-codes]

Unassigning @msaini0r due to inactivity

[mariejp]

Hello!
Is this issue still available? If so, i would like to work on it!

[ciheanyi]

Hi! I also sent a message in the Zulip, but am I able to be assigned to work on this issue?

[ciheanyi]

Hi! Thanks so much for assigning, so I finished writing the code for the enum 🥳 and I was wondering how I can go about testing before I request to push. I was a bit confused if there was some sort of suite or ready made test cases, if anybody could direct me to the right place!

[epicadk]

Can you open a pr so we can help you out?

[ciheanyi]

Whoops, realized I put this in my request not here.
@epicadk @isabelcosta

But just dropping this again for a review for the pull request. I also think there may be some software updates required that are causing the unit tests to fail, I believe markup may have recently moved to a new version that causes jinja2 to fail. When we downgraded the libraries locally, the unit tests ran successfully.