Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update mentorship_relation.py to use enum class #1151

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ciheanyi
Copy link

Fixes issue #1143. Code within isValidState function now uses an enum class when completing check.

@welcome
Copy link

welcome bot commented Apr 14, 2022

Hello there!👋 Welcome to the project!💖
Thank you and congrats 🎉 for opening your first PR on this project.✨
Please ensure your Pull Request meets the Commit Message Style Guide.
We will review it soon! Until then you can check out the README.md for more details on it.

AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct.

Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities.
Hope you have a great time here :)

@ciheanyi
Copy link
Author

ciheanyi commented Apr 19, 2022

Hi just dropping this again for a review for the pull request. I also think there may be some dependency updates required that are causing the unit tests to fail. I believe the way markup is imported may have recently deprecated for some jinja2 versions. When we modified dependency locally, unit tests ran successfully. Created bug here

@ciheanyi ciheanyi changed the title Updated mentorship_relation.py functions to use enum class Feat Update mentorship_relation.py functions to use enum class Apr 22, 2022
@ciheanyi ciheanyi changed the title Feat Update mentorship_relation.py functions to use enum class Feat: Update mentorship_relation.py functions to use enum class Apr 22, 2022
@ciheanyi ciheanyi changed the title Feat: Update mentorship_relation.py functions to use enum class Enhancement: Update mentorship_relation.py to use enum class Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant