Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: psycopg2-binary version fix #1172

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Raghunandhan8818
Copy link

@Raghunandhan8818 Raghunandhan8818 commented Aug 25, 2023

Description

Issue: The previous version of psycopg2-binary (2.8.6) was throwing an error during installation, stating "The license_file parameter is deprecated, use license_files instead."

Solution: After conducting thorough research, I upgraded the psycopg2-binary library to version 2.9.6, which resolved the aforementioned issue. And I have specified the latest version (3.3.3) for the package pre-commit so that there wont be any version conflicts in future as well. For the second issue , I have upgraded all the dependencies so that the projects runs without any errors.

Fixes #1170 and #1153

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I have tested the above installation by running pip install -r requirements.txt , and it gave no errors. All the dependencies installed successfully.

Below is the result before version upgradation.
Screenshot from 2023-08-25 21-22-46

Result after version upgradation. All the dependencies installed successfully !
image

I have updated the dependencies and the projects works without any error !!

image

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Update requirements.txt

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@welcome
Copy link

welcome bot commented Aug 25, 2023

Hello there!👋 Welcome to the project!💖
Thank you and congrats 🎉 for opening your first PR on this project.✨
Please ensure your Pull Request meets the Commit Message Style Guide.
We will review it soon! Until then you can check out the README.md for more details on it.

AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct.

Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities.
Hope you have a great time here :)

@Raghunandhan8818
Copy link
Author

Hello @isabelcosta ! This is my first try to the open source contribution and would love to contribute to this project. Let me know if I have to do anything else to get this PR merged.

@Raghunandhan8818
Copy link
Author

Raghunandhan8818 commented Aug 26, 2023

Hello @isabelcosta @vj-codes !

I was working on the dependencies and now everything works fine on python 3.7. There was problem with Jinja2 and Psycopg2-Binary .When I submitted my PR ,all the dependencies were installed successfully but it is throwing error in running the tests as TypeError: delete() got an unexpected keyword argument 'request_id' .

Shall I work on resolving those errors as well ? What should I do now ?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change in Requirement.txt for psycopg2-binary
1 participant