-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Mentorship Relation Tasks feature #128
Conversation
@m-murad you suggested more fields in a weekly meeting:
Also Current Mentorship Relation API does not return tasks yet, but I think this can be added in a later PR. This will be helpful for Current Relation screen on the android application. @systers/maintainers-mentorship-android thoughts on this? 1º Extra fields; 2º Add or not the tasks response together with the list relation API? Do this on this PR or another? |
5a1cd3b
to
84f4167
Compare
I think it would be better to do it in a separate PR |
@Dilu9218 I think too. just because its an enhancement, even though necessary, it is an enhancement, this PR has the basis of the feature. |
@isabelcosta do the enhancements in a separate PR taking this as the basis. I'm merging this one. |
OK thank your for merging it @roopalJazz. Now I should create the PR for merging gsoc18-code into develop? |
Description
Completed a simple version of the Tasks feature
Tasks feature is a JSON object part of TasksListModel which has a 1:1 relation with MentorshipRelationModel.
I'm not allowing for users to create a task which is already achieved.
A task entity will have the following format. This is the JSON response returned by the List all Tasks API:
Request Body:
New APIs:
Note: You may notice that I deleted some repeated code from tests, this is related to the setup of Mentorship Relation tests, there was a lot of repeated setup that I moved to a file which has this common setup. I did this in this PR because I was already changing this files to adapt to the new changes on MentorshipRelationModel.
Fixes #82
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Created extensive tests for each module: DAO, database model and API
Tests can be still improved, although I think the ones I developed are enough for now.
Checklist:
Code/Quality Assurance Only