Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

bug: remove default data from Relation view. #144

Open
aaryankotharii opened this issue Oct 6, 2020 · 5 comments · May be fixed by #154
Open

bug: remove default data from Relation view. #144

aaryankotharii opened this issue Oct 6, 2020 · 5 comments · May be fixed by #154
Assignees
@Zoha131
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug.

Comments

@aaryankotharii
Copy link
Contributor

Describe the bug
If the user is under no relation, Relation view shows default values for date ( i.e 1 Jan 1970), for relation-type ( i.e Mentee)

To Reproduce
Steps to reproduce the behavior:

  1. make sure you do not have an active relation.
  2. go to RelationView from Tabbar
  3. See the default placeholders.

Expected behavior
Hide the labels and show a message stating No active relation

Screenshots

Relation

Simulator (please complete the following information):

  • Device: iPhone SE 2
  • iOS: 14.0
  • Xcode: 12.0

Additional context
N/A
@aaryankotharii
Copy link
Contributor Author

This issue was mentioned by @yugantarjain in #128 as a comment.

@yugantarjain
Copy link
Contributor

yugantarjain commented Oct 6, 2020 •
edited
Loading

This issue was mentioned by @yugantarjain in #128 as a comment.

Hi @aaryankotharii! Thanks a lot for creating this issue!
Do you want to work on it or make it open to other contributors?

@aaryankotharii
Copy link
Contributor Author

Hey @yugantarjain, I reckon we can label this as a good first issue.
I will create more issues/features once we shift to Xcode 12.

@yugantarjain yugantarjain added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Hacktoberfest Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Oct 7, 2020
@Zoha131
Copy link
Contributor

Zoha131 commented Oct 14, 2020

@yugantarjain can I work on this issue?

@yugantarjain
Copy link
Contributor

@yugantarjain can I work on this issue?

@Zoha131 sure, assigned.

@yugantarjain yugantarjain removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Oct 18, 2020
Zoha131 added a commit to Zoha131/mentorship-ios that referenced this issue Oct 28, 2020
@Zoha131
remove default data from RelationView to fix anitab-org#144
8025510 
If the viewmodel is in Activity mode then only ActivityIndicator will be shown. If there is any relation then the Relation data would be shown. Otherwise, a default text will be shown to indicate an empty relation.
@Zoha131 Zoha131 linked a pull request Oct 28, 2020 that will close this issue
Open
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Zoha131 Zoha131

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove default data from RelationView Zoha131/mentorship-ios
3 participants
@Zoha131 @yugantarjain @aaryankotharii